You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/02/09 07:12:02 UTC

[GitHub] [bookkeeper] michaeljmarshall opened a new issue #2588: Clarify getAllBookies javadoc

michaeljmarshall opened a new issue #2588:
URL: https://github.com/apache/bookkeeper/issues/2588


   It looks like the javadoc for `getWritableBookies` was copied to `getAllBookies`. I'm sure that `getAllBookies` includes all bookies, not just writable ones. However, I would like to clarify what "all bookies" actually includes. Does it include bookies that have shutdown and be unavailable but are not yet decommissioned? In other words, what triggers a bookie to be removed from the list of all bookies? Is it on shutdown or on decommission?
   
   Here's the javadoc:
   
   https://github.com/apache/bookkeeper/blob/67a02db73d62188fc8a143bd9a37038ae770e90a/bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/RegistrationClient.java#L51-L63
   
   I'm happy to submit a PR to update the javadoc, if someone can clarify the intended meaning for me. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org