You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by florianverhein <gi...@git.apache.org> on 2015/03/30 08:25:55 UTC
[GitHub] spark pull request: [EC2] [SPARK-6600] Open ports in ec2/spark_ec2...
GitHub user florianverhein opened a pull request:
https://github.com/apache/spark/pull/5257
[EC2] [SPARK-6600] Open ports in ec2/spark_ec2.py to allow HDFS NFS gateway
Authorizes incoming access to master on the ports required to use the hadoop hdfs nfs gateway from outside the cluster.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/florianverhein/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5257.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5257
----
commit 72a586a68491608a32cbd5e83d0268cba8b1c18a
Author: Florian Verhein <fl...@gmail.com>
Date: 2015-03-30T04:23:40Z
[EC2] [SPARK-6600] initial impl
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [EC2] [SPARK-6600] Open ports in ec2/spark_ec2...
Posted by florianverhein <gi...@git.apache.org>.
Github user florianverhein commented on the pull request:
https://github.com/apache/spark/pull/5257#issuecomment-87570414
Some things to think about:
- Do we want an option for this (e.g. as for ganglia)? I haven't done this as I think it would be confusing at the moment, since a user would assume that the option would enable the hdfs nfs gateway on the cluster. However as far as I'm aware, spark-ec2 doesn't do this yet (#6601). So I think it would be better if the option were added as part of that work.
- Further, since the ports are opened to the authorized address, I don't see a problem in having this done by default for now.
I have tested this with a spark-ec2 cluster running the gateway (i.e. with these settings, I can mount the hfds on my local machine - which is really handy!)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [EC2] [SPARK-6600] Open ports in ec2/spark_ec2...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5257#issuecomment-87582560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29389/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [EC2] [SPARK-6600] Open ports in ec2/spark_ec2...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5257#issuecomment-87568532
[Test build #29389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29389/consoleFull) for PR 5257 at commit [`72a586a`](https://github.com/apache/spark/commit/72a586a68491608a32cbd5e83d0268cba8b1c18a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [EC2] [SPARK-6600] Open ports in ec2/spark_ec2...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5257
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [EC2] [SPARK-6600] Open ports in ec2/spark_ec2...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5257#issuecomment-87629549
I think this seems reasonable. I'll leave it open for comments for some time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [EC2] [SPARK-6600] Open ports in ec2/spark_ec2...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5257#issuecomment-87582550
[Test build #29389 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29389/consoleFull) for PR 5257 at commit [`72a586a`](https://github.com/apache/spark/commit/72a586a68491608a32cbd5e83d0268cba8b1c18a).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org