You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/11 15:03:06 UTC
[GitHub] [maven-parent] kwin opened a new pull request, #91: [MPOM-358] Activate "reporting" profile during releases
kwin opened a new pull request, #91:
URL: https://github.com/apache/maven-parent/pull/91
Only activate m-project-info-reports-p reports during "reporting" profile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] slawekjaranowski commented on a diff in pull request #91: [MPOM-358] Activate "reporting" profile during releases
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #91:
URL: https://github.com/apache/maven-parent/pull/91#discussion_r1020773745
##########
pom.xml:
##########
@@ -1080,6 +1080,7 @@ under the License.
<artifactId>maven-release-plugin</artifactId>
<configuration>
<autoVersionSubmodules>true</autoVersionSubmodules>
+ <releaseProfiles>apache-release,reporting</releaseProfiles>
Review Comment:
By the way I am for removing reporting profile at all - all site reports should be build always without special profile.
But should be discussed on dev list - maybe exist a rationale reason why we have special profile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] kwin closed pull request #91: [MPOM-358] Activate "reporting" profile during releases
Posted by GitBox <gi...@apache.org>.
kwin closed pull request #91: [MPOM-358] Activate "reporting" profile during releases
URL: https://github.com/apache/maven-parent/pull/91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] kwin commented on a diff in pull request #91: [MPOM-358] Activate "reporting" profile during releases
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #91:
URL: https://github.com/apache/maven-parent/pull/91#discussion_r1020755293
##########
pom.xml:
##########
@@ -1080,6 +1080,7 @@ under the License.
<artifactId>maven-release-plugin</artifactId>
<configuration>
<autoVersionSubmodules>true</autoVersionSubmodules>
+ <releaseProfiles>apache-release,reporting</releaseProfiles>
Review Comment:
Any idea why? IMHO building and deploying site also is very useful (at least for Msven Plugins)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] slawekjaranowski commented on a diff in pull request #91: [MPOM-358] Activate "reporting" profile during releases
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #91:
URL: https://github.com/apache/maven-parent/pull/91#discussion_r1020751475
##########
pom.xml:
##########
@@ -1080,6 +1080,7 @@ under the License.
<artifactId>maven-release-plugin</artifactId>
<configuration>
<autoVersionSubmodules>true</autoVersionSubmodules>
+ <releaseProfiles>apache-release,reporting</releaseProfiles>
Review Comment:
we use only `deploy` goal
https://github.com/apache/maven-apache-parent/blob/master/pom.xml#L248-L258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] kwin commented on a diff in pull request #91: [MPOM-358] Activate "reporting" profile during releases
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #91:
URL: https://github.com/apache/maven-parent/pull/91#discussion_r1020749974
##########
pom.xml:
##########
@@ -1080,6 +1080,7 @@ under the License.
<artifactId>maven-release-plugin</artifactId>
<configuration>
<autoVersionSubmodules>true</autoVersionSubmodules>
+ <releaseProfiles>apache-release,reporting</releaseProfiles>
Review Comment:
why not? Don't we rely on the default from https://maven.apache.org/maven-release/maven-release-plugin/perform-mojo.html#goals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] slawekjaranowski commented on a diff in pull request #91: [MPOM-358] Activate "reporting" profile during releases
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #91:
URL: https://github.com/apache/maven-parent/pull/91#discussion_r1020748754
##########
pom.xml:
##########
@@ -1080,6 +1080,7 @@ under the License.
<artifactId>maven-release-plugin</artifactId>
<configuration>
<autoVersionSubmodules>true</autoVersionSubmodules>
+ <releaseProfiles>apache-release,reporting</releaseProfiles>
Review Comment:
site is not build during release - so this has no effect here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] kwin commented on a diff in pull request #91: [MPOM-358] Activate "reporting" profile during releases
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #91:
URL: https://github.com/apache/maven-parent/pull/91#discussion_r1020758444
##########
pom.xml:
##########
@@ -1080,6 +1080,7 @@ under the License.
<artifactId>maven-release-plugin</artifactId>
<configuration>
<autoVersionSubmodules>true</autoVersionSubmodules>
+ <releaseProfiles>apache-release,reporting</releaseProfiles>
Review Comment:
I created https://issues.apache.org/jira/browse/MPOM-359 for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org