You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/25 16:07:26 UTC
[GitHub] [apisix-dashboard] idbeta opened a new issue #1127: bug: manager-api do not support PATCH method
idbeta opened a new issue #1127:
URL: https://github.com/apache/apisix-dashboard/issues/1127
# Bug report
## Describe the bug
manager-api do not support PATCH method:
when using the following three types of bodies to update node of `service`, will be error
1.
```
{
"upstream": {
"nodes": [{
"host": "172.16.238.20",
"port": 1981,
"weight": 1
}]
}
}
```
2.
```
{
"upstream": {
"nodes": {
"39.97.63.216:80": 1
}
}
}
```
return error:
```
"{\"code\":10000,\"message\":\"not a valid map: *entity.Service\",\"data\":null,\"request_id\":\"xxxxx\"}"
```
3.
```
PATCH http://127.0.0.1:9000/apisix/admin/services/your-service-id/upstream/nodes
... ...
"404 page not found\n"
```
and
`ExpectCode` of the test framework does not work
## Expected behavior
The `upstream nodes` of the service can be updated correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1127: bug: manager-api doesn't support PATCH method
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1127:
URL: https://github.com/apache/apisix-dashboard/issues/1127#issuecomment-764432654
Not urgent, I think this should be done in M2.5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1127: bug: manager-api doesn't support PATCH method
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1127:
URL: https://github.com/apache/apisix-dashboard/issues/1127#issuecomment-752418659
> @nic-chen, I had checked the apisix. And only `global_rule`, `routes`, `services`, `ssl`, `upstream`.
>
>
>
> Do `consumer` need the `Patch` method?
sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1127: bug: manager-api doesn't support PATCH method
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1127:
URL: https://github.com/apache/apisix-dashboard/issues/1127#issuecomment-751310873
Please assigned it to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1127: bug: manager-api doesn't support PATCH method
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1127:
URL: https://github.com/apache/apisix-dashboard/issues/1127#issuecomment-764432654
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1127: bug: manager-api doesn't support PATCH method
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1127:
URL: https://github.com/apache/apisix-dashboard/issues/1127#issuecomment-764434256
@juzhiyuan Help me move to M2.5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1127: bug: manager-api doesn't support PATCH method
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1127:
URL: https://github.com/apache/apisix-dashboard/issues/1127#issuecomment-753715595
not urgent, the frontend doesn't need this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1127: bug: manager-api doesn't support PATCH method
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1127:
URL: https://github.com/apache/apisix-dashboard/issues/1127#issuecomment-752372999
@nic-chen, I had checked the apisix. And only `global_rule`, `routes`, `services`, `ssl`, `upstream`.
Do `consumer` need the `Patch` method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz closed issue #1127: bug: manager-api doesn't support PATCH method
Posted by GitBox <gi...@apache.org>.
starsz closed issue #1127:
URL: https://github.com/apache/apisix-dashboard/issues/1127
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1127: bug: manager-api doesn't support PATCH method
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1127:
URL: https://github.com/apache/apisix-dashboard/issues/1127#issuecomment-800104455
I had checked the apisix and apisix-dashboard.
apisix's PATCH method:
* service
* plugin_config
* global_rules
* ssl
* routes
* upstream
apisix-dashboard's PATCH method:
* service
* plugin_config
* global_rules
* ssl
* routes
* upstream
So they are the same.I think this issue can be closed now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1127: bug: manager-api doesn't support PATCH method
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1127:
URL: https://github.com/apache/apisix-dashboard/issues/1127#issuecomment-751316039
@starsz
Patch methods for service, upstream, consumer have bug, you could refer to Patch method for SSL or route.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org