You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/08/03 19:42:47 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request, #42326: [SPARK-44661][CORE][TESTS] `getMapOutputLocation` should not throw NPE
dongjoon-hyun opened a new pull request, #42326:
URL: https://github.com/apache/spark/pull/42326
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42326: [SPARK-44661][CORE][TESTS] `getMapOutputLocation` should not throw NPE
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42326:
URL: https://github.com/apache/spark/pull/42326#issuecomment-1664679058
Thank you so much always, @viirya !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42326: [SPARK-44661][CORE][TESTS] `getMapOutputLocation` should not throw NPE
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42326:
URL: https://github.com/apache/spark/pull/42326#issuecomment-1664679561
I rebased and tested this test-only PR manually.
```
[info] MapOutputTrackerSuite:
[info] - master start and stop (638 milliseconds)
[info] - master register shuffle and fetch (169 milliseconds)
[info] - master register and unregister shuffle (43 milliseconds)
[info] - master register shuffle and unregister map output and fetch (30 milliseconds)
[info] - remote fetch (486 milliseconds)
[info] - remote fetch below max RPC message size (565 milliseconds)
[info] - min broadcast size exceeds max RPC message size (21 milliseconds)
[info] - getLocationsWithLargestOutputs with multiple outputs in same machine (107 milliseconds)
[info] - remote fetch using broadcast (6 seconds, 409 milliseconds)
[info] - equally divide map statistics tasks (15 milliseconds)
[info] - zero-sized blocks should be excluded when getMapSizesByExecutorId (62 milliseconds)
[info] - SPARK-32921: master register and unregister merge result (259 milliseconds)
[info] - SPARK-32921: get map sizes with merged shuffle (163 milliseconds)
[info] - SPARK-32921: get map statuses from merged shuffle (138 milliseconds)
[info] - SPARK-32921: get map statuses for merged shuffle block chunks (116 milliseconds)
[info] - SPARK-32921: getPreferredLocationsForShuffle with MergeStatus (939 milliseconds)
[info] - SPARK-34939: remote fetch using broadcast if broadcasted value is destroyed (15 seconds, 957 milliseconds)
[info] - SPARK-32921: test new protocol changes fetching both Map and Merge status in single RPC (18 seconds, 24 milliseconds)
[info] - SPARK-32921: unregister merge result if it is present and contains the map Id (91 milliseconds)
[info] - SPARK-32210: serialize mapStatuses to a nested Array and deserialize them (1 second, 50 milliseconds)
[info] - SPARK-32210: serialize and deserialize over 2GB compressed mapStatuses !!! IGNORED !!!
[info] - SPARK-36892: Batch fetch should be enabled in some scenarios with push based shuffle (151 milliseconds)
[info] - SPARK-36892: Batch fetch should be disabled in some scenarios with push based shuffle (79 milliseconds)
[info] - SPARK-37023: Avoid fetching merge status when useMergeResult is false (120 milliseconds)
[info] - SPARK-40480: shuffle remove should cleanup merged files as well (335 milliseconds)
[info] - SPARK-34826: Adaptive shuffle mergers (218 milliseconds)
[info] - SPARK-39553: Multi-thread unregister shuffle shouldn't throw NPE (79 milliseconds)
[info] - SPARK-42719: `MapOutputTracker#getMapLocation` should respect the config option (38 milliseconds)
[info] - SPARK-44109: Remove duplicate preferred locations of each RDD partition (226 milliseconds)
[info] - SPARK-44658: ShuffleStatus.getMapStatus should return None (13 milliseconds)
[info] - SPARK-44661: getMapOutputLocation should not throw NPE (63 milliseconds)
[info] Run completed in 49 seconds, 770 milliseconds.
[info] Total number of tests run: 30
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 30, failed 0, canceled 0, ignored 1, pending 0
[info] All tests passed.
[success] Total time: 99 s (01:39), completed Aug 3, 2023 2:35:12 PM
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #42326: [SPARK-44661][CORE][TESTS] `getMapOutputLocation` should not throw NPE
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #42326: [SPARK-44661][CORE][TESTS] `getMapOutputLocation` should not throw NPE
URL: https://github.com/apache/spark/pull/42326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42326: [SPARK-44661][CORE][TESTS] `getMapOutputLocation` should not throw NPE
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42326:
URL: https://github.com/apache/spark/pull/42326#issuecomment-1664679701
Merged to master/3.5/3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #42326: [SPARK-44661][CORE][TESTS] `getMapOutputLocation` should not throw NPE
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #42326:
URL: https://github.com/apache/spark/pull/42326#issuecomment-1664676313
Looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42326: [SPARK-44661][CORE][TESTS] `getMapOutputLocation` should not throw NPE
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42326:
URL: https://github.com/apache/spark/pull/42326#issuecomment-1664667897
Could you review this test-only PR too please, @viirya ? This includes the case where you asked~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42326: [SPARK-44661][CORE][TESTS] `getMapOutputLocation` should not throw NPE
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42326:
URL: https://github.com/apache/spark/pull/42326#issuecomment-1664661382
Since https://github.com/apache/spark/pull/42323 is merged, let me rebase this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org