You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/18 09:17:08 UTC

[GitHub] [flink] JingsongLi opened a new pull request #12220: [FLINK-14255][hive] Integrate mapred record writer to hive streaming sink

JingsongLi opened a new pull request #12220:
URL: https://github.com/apache/flink/pull/12220


   
   ## What is the purpose of the change
   
   Integrate mapred record writer to hive streaming sink.
   Hadoop Record writer can support all hive/hadoop formats.
   
   ## Brief change log
   
   - Introduce `table.exec.hive.fallback-mapred-writer` config, flink native writer better performance, but mapred writer better compatible.
   - Introduce HiveBulkWriterFactory
   - Integrate record writer
   
   ## Verifying this change
   
   `HiveTableSinkTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? JavaDocs
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JingsongLi closed pull request #12220: [FLINK-14255][hive] Integrate mapred record writer to hive streaming sink

Posted by GitBox <gi...@apache.org>.
JingsongLi closed pull request #12220:
URL: https://github.com/apache/flink/pull/12220


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12220: [FLINK-14255][hive] Integrate mapred record writer to hive streaming sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12220:
URL: https://github.com/apache/flink/pull/12220#issuecomment-630123571


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1f7420e803f6c1a3a4596457b13aa3e5bc125199",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1725",
       "triggerID" : "1f7420e803f6c1a3a4596457b13aa3e5bc125199",
       "triggerType" : "PUSH"
     }, {
       "hash" : "43791487ecb65eea3edac6956fcacb90c0da7e7f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "43791487ecb65eea3edac6956fcacb90c0da7e7f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1f7420e803f6c1a3a4596457b13aa3e5bc125199 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1725) 
   * 43791487ecb65eea3edac6956fcacb90c0da7e7f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12220: [FLINK-14255][hive] Integrate mapred record writer to hive streaming sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12220:
URL: https://github.com/apache/flink/pull/12220#issuecomment-630123571


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1f7420e803f6c1a3a4596457b13aa3e5bc125199",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1725",
       "triggerID" : "1f7420e803f6c1a3a4596457b13aa3e5bc125199",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1f7420e803f6c1a3a4596457b13aa3e5bc125199 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1725) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12220: [FLINK-14255][hive] Integrate mapred record writer to hive streaming sink

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12220:
URL: https://github.com/apache/flink/pull/12220#issuecomment-630060789


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 7b2231fb942a944c54a29c2bcc57bfaaff2fe797 (Mon May 18 09:26:40 UTC 2020)
   
   **Warnings:**
    * **4 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12220: [FLINK-14255][hive] Integrate mapred record writer to hive streaming sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12220:
URL: https://github.com/apache/flink/pull/12220#issuecomment-630123571


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1f7420e803f6c1a3a4596457b13aa3e5bc125199",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1725",
       "triggerID" : "1f7420e803f6c1a3a4596457b13aa3e5bc125199",
       "triggerType" : "PUSH"
     }, {
       "hash" : "43791487ecb65eea3edac6956fcacb90c0da7e7f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1782",
       "triggerID" : "43791487ecb65eea3edac6956fcacb90c0da7e7f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "639da607c4f4a3f23bd3ed6635cba211bf6cf8f2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "639da607c4f4a3f23bd3ed6635cba211bf6cf8f2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1f7420e803f6c1a3a4596457b13aa3e5bc125199 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1725) 
   * 43791487ecb65eea3edac6956fcacb90c0da7e7f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1782) 
   * 639da607c4f4a3f23bd3ed6635cba211bf6cf8f2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12220: [FLINK-14255][hive] Integrate mapred record writer to hive streaming sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12220:
URL: https://github.com/apache/flink/pull/12220#issuecomment-630060789


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 639da607c4f4a3f23bd3ed6635cba211bf6cf8f2 (Fri Oct 16 10:49:28 UTC 2020)
   
   **Warnings:**
    * **3 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12220: [FLINK-14255][hive] Integrate mapred record writer to hive streaming sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12220:
URL: https://github.com/apache/flink/pull/12220#issuecomment-630123571


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1f7420e803f6c1a3a4596457b13aa3e5bc125199",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1725",
       "triggerID" : "1f7420e803f6c1a3a4596457b13aa3e5bc125199",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1f7420e803f6c1a3a4596457b13aa3e5bc125199 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1725) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12220: [FLINK-14255][hive] Integrate mapred record writer to hive streaming sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12220:
URL: https://github.com/apache/flink/pull/12220#issuecomment-630123571


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1f7420e803f6c1a3a4596457b13aa3e5bc125199",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1725",
       "triggerID" : "1f7420e803f6c1a3a4596457b13aa3e5bc125199",
       "triggerType" : "PUSH"
     }, {
       "hash" : "43791487ecb65eea3edac6956fcacb90c0da7e7f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1782",
       "triggerID" : "43791487ecb65eea3edac6956fcacb90c0da7e7f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1f7420e803f6c1a3a4596457b13aa3e5bc125199 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1725) 
   * 43791487ecb65eea3edac6956fcacb90c0da7e7f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1782) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12220: [FLINK-14255][hive] Integrate mapred record writer to hive streaming sink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12220:
URL: https://github.com/apache/flink/pull/12220#issuecomment-630123571


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1f7420e803f6c1a3a4596457b13aa3e5bc125199",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1725",
       "triggerID" : "1f7420e803f6c1a3a4596457b13aa3e5bc125199",
       "triggerType" : "PUSH"
     }, {
       "hash" : "43791487ecb65eea3edac6956fcacb90c0da7e7f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1782",
       "triggerID" : "43791487ecb65eea3edac6956fcacb90c0da7e7f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "639da607c4f4a3f23bd3ed6635cba211bf6cf8f2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1789",
       "triggerID" : "639da607c4f4a3f23bd3ed6635cba211bf6cf8f2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1f7420e803f6c1a3a4596457b13aa3e5bc125199 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1725) 
   * 43791487ecb65eea3edac6956fcacb90c0da7e7f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1782) 
   * 639da607c4f4a3f23bd3ed6635cba211bf6cf8f2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1789) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12220: [FLINK-14255][hive] Integrate mapred record writer to hive streaming sink

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12220:
URL: https://github.com/apache/flink/pull/12220#issuecomment-630123571


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1f7420e803f6c1a3a4596457b13aa3e5bc125199",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1f7420e803f6c1a3a4596457b13aa3e5bc125199",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1f7420e803f6c1a3a4596457b13aa3e5bc125199 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JingsongLi commented on pull request #12220: [FLINK-14255][hive] Integrate mapred record writer to hive streaming sink

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #12220:
URL: https://github.com/apache/flink/pull/12220#issuecomment-630068280


   Previous abandoned PR: https://github.com/apache/flink/pull/12168


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org