You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/18 14:39:05 UTC
[GitHub] [doris] liyipingbest opened a new pull request, #13450: [Fix] Fix the spelling mistake of BOOST_ROOT,Boost_ROOT will work
liyipingbest opened a new pull request, #13450:
URL: https://github.com/apache/doris/pull/13450
the find_package command can use the variable of Boost_ROOT,BOOST_ROOT will not work.
# Proposed changes
Issue Number: none issue
## Problem summary
When execute shell command `sh build.sh --be ` to build the backend,the cmake tool will show can't find the boost library,because the variable of BOOST_ROOT has some spelling mistake.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] liyipingbest commented on pull request #13450: [Fix](chore): Fix the spelling mistake of BOOST_ROOT,Boost_ROOT will work
Posted by GitBox <gi...@apache.org>.
liyipingbest commented on PR #13450:
URL: https://github.com/apache/doris/pull/13450#issuecomment-1292175193
>
My cmake version : 3.22.1. Later I will show you the error. Please wait a moment.
>
> Hi @liyipingbest , would you like to provide the version of cmake you are using?
>
> I referred to the [Boost module](https://github.com/Kitware/CMake/blob/master/Modules/FindBoost.cmake#L587) in latest cmake . I think there is nothing wrong with `BOOST_ROOT` and the `Boost_ROOT` will be set because `Boost_NO_BOOST_CMAKE` is OFF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13450: [Fix] Fix the spelling mistake of BOOST_ROOT,Boost_ROOT will work
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13450:
URL: https://github.com/apache/doris/pull/13450#issuecomment-1290766315
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 37.73 seconds
load time: 561 seconds
storage size: 17154887211 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221025154058_clickbench_pr_33984.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #13450: [Fix](chore): Fix the spelling mistake of BOOST_ROOT,Boost_ROOT will work
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #13450:
URL: https://github.com/apache/doris/pull/13450#issuecomment-1292859019
Hi @liyipingbest , thanks for your prompt reply.
Here are some questions:
1. Did you use the `cmake` in `ldb_toolchain`?
2. How to reproduce this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] liyipingbest commented on pull request #13450: [fix](build) CMake fails to find the Boost package
Posted by GitBox <gi...@apache.org>.
liyipingbest commented on PR #13450:
URL: https://github.com/apache/doris/pull/13450#issuecomment-1293666089
> @liyipingbest Would you like to provide the information about the OS (e.g. Ubuntu 22.04 x86_64) , cmake and the compiler? Just in case if somebody else would encounter similar problem.
Yes,My OS is Ubuntu 22.04 x86_64, cmake 3.22.1 compiler: gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] liyipingbest commented on pull request #13450: [Fix](chore): Fix the spelling mistake of BOOST_ROOT,Boost_ROOT will work
Posted by GitBox <gi...@apache.org>.
liyipingbest commented on PR #13450:
URL: https://github.com/apache/doris/pull/13450#issuecomment-1293574222
> Hi @liyipingbest , thanks for your prompt reply.
>
> Here are some questions:
>
> 1. Did you use the `cmake` in `ldb_toolchain`?
> 2. How to reproduce this issue?
Answer:
1. No. I used the build.sh script directly and never set something about ldb_toolchain.
2. Pull down the doris repo to a new local dir. Then just execute ./build.sh --be. The error will occur. If there is no error when you first time build the backend.Just delete the `./be/build_Release` , ```sh
rm -rf ./be/build_Release ``` .Then exe `build.sh --be` again, error occurs.I have repeated this phenomenon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] liyipingbest commented on pull request #13450: [Fix](chore): Fix the spelling mistake of BOOST_ROOT,Boost_ROOT will work
Posted by GitBox <gi...@apache.org>.
liyipingbest commented on PR #13450:
URL: https://github.com/apache/doris/pull/13450#issuecomment-1293573965
> Hi @liyipingbest , thanks for your prompt reply.
>
> Here are some questions:
>
> 1. Did you use the `cmake` in `ldb_toolchain`?
> 2. How to reproduce this issue?
Answer:
1. No. I used the build.sh script directly and never set something about ldb_toolchain.
2. Pull down the doris repo to a new local dir. Then just execute ./build.sh --be. The error will occur. If there is no error when you first time build the backend.Just delete the `./be/build_Release` , ```sh
rm -rf ./be/build_Release ``` .Then exe `build.sh --be` again, error occurs.I have repeated this phenomenon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13450: [Fix] Fix the spelling mistake of BOOST_ROOT,Boost_ROOT will work
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13450:
URL: https://github.com/apache/doris/pull/13450#issuecomment-1284772512
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 40.4 seconds
load time: 595 seconds
storage size: 17154768670 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221020092412_clickbench_pr_31679.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #13450: [Fix](chore): Fix the spelling mistake of BOOST_ROOT,Boost_ROOT will work
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #13450:
URL: https://github.com/apache/doris/pull/13450#issuecomment-1291700298
Hi @liyipingbest , would you like to provide the version of cmake you are using?
I referred to the [Boost module](https://github.com/Kitware/CMake/blob/master/Modules/FindBoost.cmake#L587) in latest cmake . I think there is nothing wrong with `BOOST_ROOT` and the `Boost_ROOT` will be set because `Boost_NO_BOOST_CMAKE` is OFF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13450: [Fix](chore): Fix the spelling mistake of BOOST_ROOT,Boost_ROOT will work
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13450:
URL: https://github.com/apache/doris/pull/13450#issuecomment-1293597095
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] liyipingbest commented on pull request #13450: [fix](build) CMake fails to find the Boost package
Posted by GitBox <gi...@apache.org>.
liyipingbest commented on PR #13450:
URL: https://github.com/apache/doris/pull/13450#issuecomment-1293660360
> Ubuntu 22.04 x86_64
Yes,My OS is Ubuntu 22.04 x86_64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #13450: [Fix](chore): Fix the spelling mistake of BOOST_ROOT,Boost_ROOT will work
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #13450:
URL: https://github.com/apache/doris/pull/13450#issuecomment-1293590798
@liyipingbest Would you like to provide the information about the OS (e.g. Ubuntu 22.04 x86_64) , cmake and the compiler? Just in case if somebody else would encounter similar problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13450: [Fix](chore): Fix the spelling mistake of BOOST_ROOT,Boost_ROOT will work
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13450:
URL: https://github.com/apache/doris/pull/13450#issuecomment-1293597153
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13450: [fix](build) CMake fails to find the Boost package
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13450:
URL: https://github.com/apache/doris/pull/13450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #13450: [Fix](chore): Fix the spelling mistake of BOOST_ROOT,Boost_ROOT will work
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #13450:
URL: https://github.com/apache/doris/pull/13450#issuecomment-1291680842
cc @adonis0147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org