You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Navis Ryu <na...@nexr.com> on 2014/05/21 03:47:03 UTC
Review Request 21748: Fix test fails for both hadoop-1 and hadoop-2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21748/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-7095
https://issues.apache.org/jira/browse/HIVE-7095
Repository: hive-git
Description
-------
There are some try to fix test results for hadoop-2(HIVE-6838, HIVE-6979, etc.). But these remained problems for hadoop-1. Let's finish this here, not prolonging output ping-pongs between two versions.
1. Data size in explain result is different
bucketizedhiveinputformat.q
2. forced bucketing(=2) does not make two files in hadoop-1.
groupby_sort_1.q
groupby_sort_skew_1.q
3. Column stats of srcpart, which has loaded a file rather than inserted, has COLUMN_STATS_ACCURATE=true, numRows=0, rawDataSize=0 for hadoop-2, which seemed wrong.
sample8.q
transform_ppr1.q
transform_ppr2.q
union_ppr.q
4. Iteration order of table properties for show create table is different.
nullformatCTAS.q
show_create_table_alter.q
5. Iteration order of show table properties is different
unset_table_view_property.q
Diffs
-----
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 6fcc510
itests/util/src/main/java/org/apache/hadoop/hive/ql/hooks/ShowMapredStatsHook.java PRE-CREATION
itests/util/src/main/java/org/apache/hadoop/hive/ql/hooks/VerifyNumReducersHook.java 4b2c184
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 9040d9b
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 7c175aa
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java 1f782db
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java dab8610
ql/src/test/queries/clientpositive/bucketizedhiveinputformat.q d2e12e8
ql/src/test/queries/clientpositive/groupby_sort_1.q 7401a9c
ql/src/test/queries/clientpositive/groupby_sort_1_23.q PRE-CREATION
ql/src/test/queries/clientpositive/groupby_sort_skew_1.q db0faa0
ql/src/test/queries/clientpositive/groupby_sort_skew_1_23.q PRE-CREATION
ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 8428dbf
ql/src/test/results/clientpositive/groupby_sort_1.q.out d684158
ql/src/test/results/clientpositive/groupby_sort_1_23.q.out PRE-CREATION
ql/src/test/results/clientpositive/groupby_sort_skew_1.q.out 8d731b9
ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out PRE-CREATION
ql/src/test/results/clientpositive/nullformatCTAS.q.out 85eaf37
ql/src/test/results/clientpositive/show_create_table_alter.q.out c4baa5b
Diff: https://reviews.apache.org/r/21748/diff/
Testing
-------
Thanks,
Navis Ryu
Re: Review Request 21748: Fix test fails for both hadoop-1 and hadoop-2
Posted by Navis Ryu <na...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21748/
-----------------------------------------------------------
(Updated May 22, 2014, 1:07 a.m.)
Review request for hive.
Changes
-------
Fixed test fails
Bugs: HIVE-7095
https://issues.apache.org/jira/browse/HIVE-7095
Repository: hive-git
Description
-------
There are some try to fix test results for hadoop-2(HIVE-6838, HIVE-6979, etc.). But these remained problems for hadoop-1. Let's finish this here, not prolonging output ping-pongs between two versions.
1. Data size in explain result is different
bucketizedhiveinputformat.q
2. forced bucketing(=2) does not make two files in hadoop-1.
groupby_sort_1.q
groupby_sort_skew_1.q
3. Column stats of srcpart, which has loaded a file rather than inserted, has COLUMN_STATS_ACCURATE=true, numRows=0, rawDataSize=0 for hadoop-2, which seemed wrong.
sample8.q
transform_ppr1.q
transform_ppr2.q
union_ppr.q
4. Iteration order of table properties for show create table is different.
nullformatCTAS.q
show_create_table_alter.q
5. Iteration order of show table properties is different
unset_table_view_property.q
Diffs (updated)
-----
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 6fcc510
itests/util/src/main/java/org/apache/hadoop/hive/ql/hooks/ShowMapredStatsHook.java PRE-CREATION
itests/util/src/main/java/org/apache/hadoop/hive/ql/hooks/VerifyNumReducersHook.java 4b2c184
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 9040d9b
ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java 8ba2b49
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 7c175aa
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java 1f782db
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java dab8610
ql/src/test/queries/clientpositive/bucketizedhiveinputformat.q d2e12e8
ql/src/test/queries/clientpositive/groupby_sort_1.q 7401a9c
ql/src/test/queries/clientpositive/groupby_sort_1_23.q PRE-CREATION
ql/src/test/queries/clientpositive/groupby_sort_skew_1.q db0faa0
ql/src/test/queries/clientpositive/groupby_sort_skew_1_23.q PRE-CREATION
ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 8428dbf
ql/src/test/results/clientpositive/groupby_sort_1.q.out d684158
ql/src/test/results/clientpositive/groupby_sort_1_23.q.out PRE-CREATION
ql/src/test/results/clientpositive/groupby_sort_skew_1.q.out 8d731b9
ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out PRE-CREATION
ql/src/test/results/clientpositive/nullformatCTAS.q.out 85eaf37
ql/src/test/results/clientpositive/show_create_table_alter.q.out c4baa5b
ql/src/test/results/clientpositive/show_tblproperties.q.out c60e710
ql/src/test/results/clientpositive/unset_table_view_property.q.out f4f1e91
Diff: https://reviews.apache.org/r/21748/diff/
Testing
-------
Thanks,
Navis Ryu