Take 3: Fwd: Re: [PATCH] Re: Code cleanup: Harmonized tests

[e....@gmx.net]

Forgot to send to list. correction.

--- Weitergeleitete Nachricht / Forwarded Message ---
Date: Tue, 2 Sep 2003 21:33:36 +0200 (MEST)
From: e.huelsmann@gmx.net
To: "B. W. Fitzpatrick" <fi...@red-bean.com>
Subject: Re: [PATCH] Re: Code cleanup: Harmonized tests (Take 2)

> Fitz,
> 
> As discussed in IRC: the same patch (take 3) without the changes to
> commit_tests.py 15.
> I gzip'ed it, because my last mail to the list with the patch attached got
> a
> bit big.
> 
> bye,
> 
> Erik.
> 
> > Hey CMike, I'm planning on reviewing this in the new few days.
> > 
> > -Fitz
> > 

-- 
COMPUTERBILD 15/03: Premium-e-mail-Dienste im Test
--------------------------------------------------
1. GMX TopMail - Platz 1 und Testsieger!
2. GMX ProMail - Platz 2 und Preis-Qualitätssieger!
3. Arcor - 4. web.de - 5. T-Online - 6. freenet.de - 7. daybyday - 8. e-Post

Re: Take 3: Fwd: Re: [PATCH] Re: Code cleanup: Harmonized tests

["B. W. Fitzpatrick" <fi...@red-bean.com>]

e.huelsmann@gmx.net writes:
> Forgot to send to list. correction.
> 
> --- Weitergeleitete Nachricht / Forwarded Message ---
> Date: Tue, 2 Sep 2003 21:33:36 +0200 (MEST)
> From: e.huelsmann@gmx.net
> To: "B. W. Fitzpatrick" <fi...@red-bean.com>
> Subject: Re: [PATCH] Re: Code cleanup: Harmonized tests (Take 2)
> 
> > Fitz,
> > 
> > As discussed in IRC: the same patch (take 3) without the changes to
> > commit_tests.py 15.
> > I gzip'ed it, because my last mail to the list with the patch attached got
> > a
> > bit big.

Committed in Revision 6994.

*thud*

First, thanks for the patch.  I'm *really* glad to have almost all of
this conversion done (see below).

Second, please don't ever submit a patch that big again. :-)

Other notes:

svntest.SVNAnyOutput -> SVNAnyOutput should have been a separate patch.

Renaming stat_output, etc. to output should have been a separate patch.

No whitespace after opening paren of a function in the python test
suite (Remember, just echo the style of the code you're working in).
There were a bunch of these.  Ugh.

I skipped schedule_tests.py because there were a bunch of changes that
weren't directly related to the "return -> exception" change, and it
looks like your patch dropped part of the test (of expected_output vs
output) in revert_nested_adds.  Maybe I'm missing something and you
could explain it to me--I was getting a little punchy towards the end
of reviewing that patch.

-Fitz

--
Brian W. Fitzpatrick    <fi...@red-bean.com>   http://www.red-bean.com/fitz/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org