You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2007/09/28 18:14:10 UTC
svn commit: r580400 - in /jakarta/jmeter/trunk/src:
core/org/apache/jmeter/config/gui/ core/org/apache/jmeter/samplers/gui/
core/org/apache/jmeter/visualizers/gui/ reports/org/apache/jmeter/report/gui/
Author: sebb
Date: Fri Sep 28 09:14:09 2007
New Revision: 580400
URL: http://svn.apache.org/viewvc?rev=580400&view=rev
Log:
Remove redundant getPrintableComponent() overrides
Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/config/gui/AbstractConfigGui.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/samplers/gui/AbstractSamplerGui.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/visualizers/gui/AbstractVisualizer.java
jakarta/jmeter/trunk/src/reports/org/apache/jmeter/report/gui/AbstractReportGui.java
Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/config/gui/AbstractConfigGui.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/config/gui/AbstractConfigGui.java?rev=580400&r1=580399&r2=580400&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/config/gui/AbstractConfigGui.java (original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/config/gui/AbstractConfigGui.java Fri Sep 28 09:14:09 2007
@@ -21,21 +21,17 @@
import java.util.Arrays;
import java.util.Collection;
-import javax.swing.JComponent;
import javax.swing.JPopupMenu;
import org.apache.jmeter.gui.AbstractJMeterGuiComponent;
import org.apache.jmeter.gui.util.MenuFactory;
-import org.apache.jmeter.visualizers.Printable;
/**
* This is the base class for JMeter GUI components which provide configuration
* for some other component.
*
- * @author Michael Stover
- * @version $Revision$
*/
-public abstract class AbstractConfigGui extends AbstractJMeterGuiComponent implements Printable {
+public abstract class AbstractConfigGui extends AbstractJMeterGuiComponent {
/**
* When a user right-clicks on the component in the test tree, or selects
* the edit menu when the component is selected, the component will be asked
@@ -62,15 +58,5 @@
*/
public Collection getMenuCategories() {
return Arrays.asList(new String[] { MenuFactory.CONFIG_ELEMENTS });
- }
-
- /**
- * Subclasses need to over this method, if they wish to return something
- * other than the Visualizer itself.
- *
- * @return
- */
- public JComponent getPrintableComponent() {
- return this;
}
}
Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/samplers/gui/AbstractSamplerGui.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/samplers/gui/AbstractSamplerGui.java?rev=580400&r1=580399&r2=580400&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/samplers/gui/AbstractSamplerGui.java (original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/samplers/gui/AbstractSamplerGui.java Fri Sep 28 09:14:09 2007
@@ -21,20 +21,16 @@
import java.util.Arrays;
import java.util.Collection;
-import javax.swing.JComponent;
import javax.swing.JPopupMenu;
import org.apache.jmeter.gui.AbstractJMeterGuiComponent;
import org.apache.jmeter.gui.util.MenuFactory;
-import org.apache.jmeter.visualizers.Printable;
/**
* This is the base class for JMeter GUI components which manage samplers.
*
- * @author Michael Stover
- * @version $Revision$
*/
-public abstract class AbstractSamplerGui extends AbstractJMeterGuiComponent implements Printable {
+public abstract class AbstractSamplerGui extends AbstractJMeterGuiComponent {
/**
* When a user right-clicks on the component in the test tree, or selects
* the edit menu when the component is selected, the component will be asked
@@ -61,15 +57,5 @@
*/
public Collection getMenuCategories() {
return Arrays.asList(new String[] { MenuFactory.SAMPLERS });
- }
-
- /**
- * Subclasses need to over this method, if they wish to return something
- * other than the Visualizer itself.
- *
- * @return
- */
- public JComponent getPrintableComponent() {
- return this;
}
}
Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/visualizers/gui/AbstractVisualizer.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/visualizers/gui/AbstractVisualizer.java?rev=580400&r1=580399&r2=580400&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/visualizers/gui/AbstractVisualizer.java (original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/visualizers/gui/AbstractVisualizer.java Fri Sep 28 09:14:09 2007
@@ -27,7 +27,6 @@
import javax.swing.JButton;
import javax.swing.JCheckBox;
-import javax.swing.JComponent;
import javax.swing.JPopupMenu;
import javax.swing.event.ChangeEvent;
import javax.swing.event.ChangeListener;
@@ -347,16 +346,6 @@
*/
protected void setModel(ResultCollector collector) {
this.collector = collector;
- }
-
- /**
- * Subclasses need to over this method, if they wish to return something
- * other than the Visualizer itself.
- *
- * @return
- */
- public JComponent getPrintableComponent() {
- return this;
}
public void clearGui(){
Modified: jakarta/jmeter/trunk/src/reports/org/apache/jmeter/report/gui/AbstractReportGui.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/reports/org/apache/jmeter/report/gui/AbstractReportGui.java?rev=580400&r1=580399&r2=580400&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/reports/org/apache/jmeter/report/gui/AbstractReportGui.java (original)
+++ jakarta/jmeter/trunk/src/reports/org/apache/jmeter/report/gui/AbstractReportGui.java Fri Sep 28 09:14:09 2007
@@ -1,4 +1,3 @@
-//$Header$
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
@@ -25,7 +24,6 @@
import java.util.Arrays;
import java.util.Collection;
-import javax.swing.JComponent;
import javax.swing.JLabel;
import javax.swing.JMenu;
import javax.swing.JPopupMenu;
@@ -36,21 +34,13 @@
import org.apache.jmeter.gui.util.VerticalPanel;
import org.apache.jmeter.testelement.TestElement;
import org.apache.jmeter.util.JMeterUtils;
-import org.apache.jmeter.visualizers.Printable;
-import org.apache.jorphan.logging.LoggingManager;
-import org.apache.log.Logger;
/**
- * @author Peter Lin
*
* This is the abstract base for report gui's
*/
-public abstract class AbstractReportGui extends AbstractJMeterGuiComponent
- implements Printable
+public abstract class AbstractReportGui extends AbstractJMeterGuiComponent
{
- /** Logging */
- private static Logger log = LoggingManager.getLoggerForClass();
-
/**
*
*/
@@ -115,14 +105,5 @@
titleLabel.setFont(curFont.deriveFont((float) curFont.getSize() + 4));
titleLabel.setBackground(Color.white);
return titleLabel;
- }
- /**
- * Subclasses need to over this method, if they wish to return something
- * other than the Visualizer itself.
- *
- * @return
- */
- public JComponent getPrintableComponent() {
- return this;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org