You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2019/03/21 23:47:30 UTC

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell 

Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12830


Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell
......................................................................

IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

IMPALA-8317 added a patch that uses OrderedDict, which is not available
on Python 2.6 and lower. This patch fixes the issue by using the
OrderedDict from ordereddict third-party library when running on Python
2.6 and lower.

Testing:
- Ran all E2E shell tests on CentOS 6 which uses Python 2.6

Change-Id: Iab1a33542319e9bb75d806bfd38b158995b54aa9
---
M shell/option_parser.py
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/12830/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab1a33542319e9bb75d806bfd38b158995b54aa9
Gerrit-Change-Number: 12830
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12830 )

Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell
......................................................................

IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

IMPALA-8317 added a patch that uses OrderedDict, which is not available
on Python 2.6 or lower. The patch in IMPALA-8317 also requires a newer
version of configparser to handle duplicate keys, which is not available
in Python 2.6. This patch fixes the issue by using the OrderedDict from
ordereddict third-party library when running on Python 2.6 or lower and
using configparser from the backport.

Testing:
- Ran all E2E shell tests on Python 2.6 and 2.7

Change-Id: Iab1a33542319e9bb75d806bfd38b158995b54aa9
Reviewed-on: http://gerrit.cloudera.org:8080/12830
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M infra/python/deps/requirements.txt
M shell/option_parser.py
2 files changed, 10 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab1a33542319e9bb75d806bfd38b158995b54aa9
Gerrit-Change-Number: 12830
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 )

Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell
......................................................................


Patch Set 2: Code-Review+1

I'm not super clear on our stance on adding new thirdparty libs in python requirements (we actually do in a few places, ordereddict for ex) . So, I prefer if someone more knowledgeable in that matter can +2 it. Patch LGTM otherwise.


-- 
To view, visit http://gerrit.cloudera.org:8080/12830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1a33542319e9bb75d806bfd38b158995b54aa9
Gerrit-Change-Number: 12830
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 19:58:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 )

Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell
......................................................................


Patch Set 1:

I'm running the private build on CentOS to verify the fix.


-- 
To view, visit http://gerrit.cloudera.org:8080/12830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1a33542319e9bb75d806bfd38b158995b54aa9
Gerrit-Change-Number: 12830
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 23:48:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12830 )

Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell
......................................................................

IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

IMPALA-8317 added a patch that uses OrderedDict, which is not available
on Python 2.6 or lower. The patch in IMPALA-8317 also requires a newer
version of configparser to handle duplicate keys, which is not available
in Python 2.6. This patch fixes the issue by using the OrderedDict from
ordereddict third-party library when running on Python 2.6 or lower and
using configparser from the backport.

Testing:
- Ran all E2E shell tests on Python 2.6 and 2.7

Change-Id: Iab1a33542319e9bb75d806bfd38b158995b54aa9
---
M infra/python/deps/requirements.txt
M shell/option_parser.py
2 files changed, 10 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/12830/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab1a33542319e9bb75d806bfd38b158995b54aa9
Gerrit-Change-Number: 12830
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 )

Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2524/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1a33542319e9bb75d806bfd38b158995b54aa9
Gerrit-Change-Number: 12830
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 19:17:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 )

Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1a33542319e9bb75d806bfd38b158995b54aa9
Gerrit-Change-Number: 12830
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 23:52:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 )

Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1a33542319e9bb75d806bfd38b158995b54aa9
Gerrit-Change-Number: 12830
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 23:26:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 )

Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2515/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1a33542319e9bb75d806bfd38b158995b54aa9
Gerrit-Change-Number: 12830
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 00:29:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 )

Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3949/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/12830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1a33542319e9bb75d806bfd38b158995b54aa9
Gerrit-Change-Number: 12830
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 23:26:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 )

Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1a33542319e9bb75d806bfd38b158995b54aa9
Gerrit-Change-Number: 12830
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Mar 2019 04:14:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 )

Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell
......................................................................


Patch Set 2: Code-Review+2

lets get this in to fix the broken builds. We can revert later if anyone has any objections.


-- 
To view, visit http://gerrit.cloudera.org:8080/12830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1a33542319e9bb75d806bfd38b158995b54aa9
Gerrit-Change-Number: 12830
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 23:26:31 +0000
Gerrit-HasComments: No