You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/27 06:30:47 UTC
[GitHub] [skywalking-java] cyberdak opened a new pull request, #367: [typo fix] fix milestone link
cyberdak opened a new pull request, #367:
URL: https://github.com/apache/skywalking-java/pull/367
fix changs.md .
No any code changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #367: [typo fix] fix milestone link
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #367:
URL: https://github.com/apache/skywalking-java/pull/367#issuecomment-1293097844
That is not how it works. In SkyWalking, issue's milestone(main repo's) is the only place to track planned things. This repo's milestone is for cataloging the PR. In the release tag, you have already known which merged PRs are included. There is not much point to link them again.
On the other hand, some proposals may be discussed, even rejected(so no PR), in the main issue tracker. This is why we link to it from here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] cyberdak commented on pull request #367: [typo fix] fix milestone link
Posted by GitBox <gi...@apache.org>.
cyberdak commented on PR #367:
URL: https://github.com/apache/skywalking-java/pull/367#issuecomment-1293070138
@wu-sheng review please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] cyberdak closed pull request #367: [typo fix] fix milestone link
Posted by GitBox <gi...@apache.org>.
cyberdak closed pull request #367: [typo fix] fix milestone link
URL: https://github.com/apache/skywalking-java/pull/367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #367: [typo fix] fix milestone link
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #367:
URL: https://github.com/apache/skywalking-java/pull/367#issuecomment-1293079403
The old one is wrong, but yours is wrong too. Milestone is managed in the main repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] cyberdak commented on pull request #367: [typo fix] fix milestone link
Posted by GitBox <gi...@apache.org>.
cyberdak commented on PR #367:
URL: https://github.com/apache/skywalking-java/pull/367#issuecomment-1293092564
There is also a "Java 8.9.0" milestone in the main repository , but this repository's milestone links to 39 prs , the main milestone only links to 19 prs which loss some.
If doc link to the main milestone , we should fix the main milestone.
this repo's milestone : https://github.com/apache/skywalking-java/milestone/2?closed=1
the main repo's milestone : https://github.com/apache/skywalking/milestone/108?closed=1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org