You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/10/06 00:55:04 UTC
Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in
Mesos containerizer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55334/#review187225
-----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp
Lines 1186-1202 (patched)
<https://reviews.apache.org/r/55334/#comment264161>
@gilbert, I realized one thing: should this be moved to or duplicated in `containerizer::prepare()`, after the `provisionInfo` is returned from `provisioner::provision()` finishes? In the chained callback there, `container->config` could be updated one more time if some rootfs is provisioned.
- Zhitao Li
On Sept. 26, 2017, 7:09 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55334/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 7:09 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-6894
> https://issues.apache.org/jira/browse/MESOS-6894
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch includes the following change:
> - Checkpointed `ContainerConfig` used to launch a container;
> - Added helper function to read checkpointed `ContainerConfig`;
> - Recovered `ContainerConfig`.
> - Make `ContainerConfig` Option in `Container` struct to indicate whether recovered.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp cc23b4d91be16fc95a131c09d07378b801e34d6f
> src/slave/containerizer/mesos/containerizer.cpp 4d5dc13f363f5d8886983d7dd06a5cecc177c345
> src/slave/containerizer/mesos/paths.hpp a03f15e01e8eb8a1326baad8d7db96a79d785482
> src/slave/containerizer/mesos/paths.cpp 0c61c20c345a327ec469b382558aaeed0280e754
>
>
> Diff: https://reviews.apache.org/r/55334/diff/9/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>