You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/27 12:03:25 UTC

[GitHub] [shardingsphere] jingshanglu opened a new pull request #7938: Improve the definition of select

jingshanglu opened a new pull request #7938:
URL: https://github.com/apache/shardingsphere/pull/7938


   ### Background
   `select .... for update into ...` is not supported
   
   ### What is the purpose of the change
   Improve the definition of select
   
   
   ### Changes in this pull request:
   - change the definition of select
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #7938: Improve the definition of select

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #7938:
URL: https://github.com/apache/shardingsphere/pull/7938


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #7938: Improve the definition of select

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #7938:
URL: https://github.com/apache/shardingsphere/pull/7938#issuecomment-717282354


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7938?src=pr&el=h1) Report
   > Merging [#7938](https://codecov.io/gh/apache/shardingsphere/pull/7938?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/19597b9dad4e4ea8a2459215734f1eabf24505ec?el=desc) will **decrease** coverage by `0.02%`.
   > The diff coverage is `73.17%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7938/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7938?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #7938      +/-   ##
   ============================================
   - Coverage     74.71%   74.69%   -0.03%     
     Complexity      537      537              
   ============================================
     Files          1444     1444              
     Lines         22747    22762      +15     
     Branches       4067     4072       +5     
   ============================================
   + Hits          16996    17001       +5     
   - Misses         4657     4660       +3     
   - Partials       1094     1101       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7938?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...sitor/statement/impl/MySQLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/7938/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL3N0YXRlbWVudC9pbXBsL015U1FMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `78.16% <73.17%> (-1.14%)` | `1.00 <0.00> (ø)` | |
   | [...ext/transaction/GovernanceTransactionContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/7938/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1jb3JlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC90cmFuc2FjdGlvbi9Hb3Zlcm5hbmNlVHJhbnNhY3Rpb25Db250ZXh0cy5qYXZh) | `93.33% <0.00%> (-6.67%)` | `0.00% <0.00%> (ø%)` | |
   | [...gsphere/proxy/config/ProxyConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/7938/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9jb25maWcvUHJveHlDb25maWd1cmF0aW9uTG9hZGVyLmphdmE=) | `50.00% <0.00%> (+2.94%)` | `0.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7938?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7938?src=pr&el=footer). Last update [19597b9...c52b722](https://codecov.io/gh/apache/shardingsphere/pull/7938?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org