[GitHub] [apisix] spacewander commented on issue #2633: [discuss] `checker:report_xx` is more appropriate in the log phase

[GitBox <gi...@apache.org>]

spacewander commented on issue #2633:
URL: https://github.com/apache/apisix/issues/2633#issuecomment-723696225


   It is to make the report happened in time. If we only count the failure in the log phase, the operation of circuit-breaker will be delayed.
   
   > In the nginx framework, the report node state is more recommended in the log phase
   
   No. Nginx does the same thing. Nginx counts the failure just before the retrying:
   https://github.com/nginx/nginx/blob/ad2b9944b012699c225d75e63aeadf61d9ce3367/src/http/ngx_http_upstream.c#L4189
   
   If you still think the behavior is not appropriate, please contact Nginx's developers. We just follow their way.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org