You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2015/08/31 17:12:45 UTC
Re: Review Request 37953: SQLA: add property validation check for BP
oozie/hive, about SQLA should be available only for stack 2.3+
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37953/
-----------------------------------------------------------
(Updated Сер. 31, 2015, 3:12 після полудня)
Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Sumit Mohanty.
Summary (updated)
-----------------
SQLA: add property validation check for BP oozie/hive, about SQLA should be available only for stack 2.3+
Repository: ambari
Description
-------
.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 70d1907
Diff: https://reviews.apache.org/r/37953/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 37953: SQLA: add property validation check for BP
oozie/hive, about SQLA should be available only for stack 2.3+
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37953/#review97293
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Sept. 1, 2015, 3:40 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37953/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 3:40 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Sumit Mohanty.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 70d1907
>
> Diff: https://reviews.apache.org/r/37953/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 37953: SQLA: add property validation check for BP
oozie/hive, about SQLA should be available only for stack 2.3+
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37953/#review97301
-----------------------------------------------------------
Ship it!
The basic change looks ok to me, but unit tests should be added to verify this change.
Could the author also please update the review with the associated JIRA, and a description of the patch?
Thanks.
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java (line 103)
<https://reviews.apache.org/r/37953/#comment153137>
Could the author of this patch please add new unit tests to verify this change to the validator?
Thanks.
- Robert Nettleton
On Sept. 1, 2015, 3:40 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37953/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 3:40 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Sumit Mohanty.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 70d1907
>
> Diff: https://reviews.apache.org/r/37953/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 37953: SQLA: add property validation check for BP
oozie/hive, about SQLA should be available only for stack 2.3+
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
> On Вер. 1, 2015, 4:35 після полудня, Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java, line 107
> > <https://reviews.apache.org/r/37953/diff/1-2/?file=1060321#file1060321line107>
> >
> > Shouldnt this be 2.3.2.0?
No. 2.3.2 it's repo version but not HDP. Today me and Sumit, taled with Bob Nettleton and decided to do in this way. Repo version we can't get on BP validation phase, because we will have it only after deploy started.
> On Вер. 1, 2015, 4:35 після полудня, Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java, line 118
> > <https://reviews.apache.org/r/37953/diff/1-2/?file=1060321#file1060321line118>
> >
> > Same as above.
The same as above.
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37953/#review97299
-----------------------------------------------------------
On Вер. 1, 2015, 3:40 після полудня, Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37953/
> -----------------------------------------------------------
>
> (Updated Вер. 1, 2015, 3:40 після полудня)
>
>
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Sumit Mohanty.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 70d1907
>
> Diff: https://reviews.apache.org/r/37953/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 37953: SQLA: add property validation check for BP
oozie/hive, about SQLA should be available only for stack 2.3+
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37953/#review97299
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java (line 107)
<https://reviews.apache.org/r/37953/#comment153131>
Shouldnt this be 2.3.2.0?
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java (line 118)
<https://reviews.apache.org/r/37953/#comment153132>
Same as above.
- Jayush Luniya
On Sept. 1, 2015, 3:40 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37953/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 3:40 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Sumit Mohanty.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 70d1907
>
> Diff: https://reviews.apache.org/r/37953/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 37953: SQLA: add property validation check for BP
oozie/hive, about SQLA should be available only for stack 2.3+
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37953/
-----------------------------------------------------------
(Updated Вер. 2, 2015, 10:43 до полудня)
Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Sumit Mohanty.
Repository: ambari
Description
-------
.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 70d1907
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java 0b1573b
Diff: https://reviews.apache.org/r/37953/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 37953: SQLA: add property validation check for BP
oozie/hive, about SQLA should be available only for stack 2.3+
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37953/
-----------------------------------------------------------
(Updated Вер. 1, 2015, 3:40 після полудня)
Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Sumit Mohanty.
Repository: ambari
Description
-------
.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 70d1907
Diff: https://reviews.apache.org/r/37953/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 37953: SQLA: add property validation check for BP
oozie/hive, about SQLA should be available only for stack 2.3+
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On Aug. 31, 2015, 6:39 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java, line 115
> > <https://reviews.apache.org/r/37953/diff/1/?file=1060321#file1060321line115>
> >
> > We should check for equal to or higher than 2.3.2 and type HDP. Other stacks may have different version and type combination for the same feature.
Please dont use parseFloat as we have logic to explicitly replace stack versions based on function being called in white labeling. Use something like the following for version check. Also as Sumit mentioned we should check maintainence release version.
ambari/ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
# some versions of HDP don't need the lzo compression libraries
target_version_needs_compression_libraries = compare_versions(
format_hdp_stack_version(params.version), '2.2.1.0') >= 0
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37953/#review97118
-----------------------------------------------------------
On Aug. 31, 2015, 3:12 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37953/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 3:12 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Sumit Mohanty.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 70d1907
>
> Diff: https://reviews.apache.org/r/37953/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 37953: SQLA: add property validation check for BP
oozie/hive, about SQLA should be available only for stack 2.3+
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37953/#review97118
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java (line 115)
<https://reviews.apache.org/r/37953/#comment152877>
We should check for equal to or higher than 2.3.2 and type HDP. Other stacks may have different version and type combination for the same feature.
- Sumit Mohanty
On Aug. 31, 2015, 3:12 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37953/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 3:12 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Sumit Mohanty.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 70d1907
>
> Diff: https://reviews.apache.org/r/37953/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>