You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Zheng Shao (JIRA)" <ji...@apache.org> on 2009/03/20 08:04:50 UTC
[jira] Created: (HIVE-356) Remove Arrays.asList calls
Remove Arrays.asList calls
--------------------------
Key: HIVE-356
URL: https://issues.apache.org/jira/browse/HIVE-356
Project: Hadoop Hive
Issue Type: Improvement
Components: Serializers/Deserializers
Affects Versions: 0.3.0
Reporter: Zheng Shao
Assignee: Zheng Shao
There are some unnecessary Arrays.asList calls in UnionStructObjectInspector. Profiling showed that it takes up to 3% of the CPU.
We should remove that unnecessary call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-356) Remove Arrays.asList calls
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-356:
----------------------------
Attachment: HIVE-356.1.patch
Split the code for handling Object[] and handling List<Object>.
> Remove Arrays.asList calls
> --------------------------
>
> Key: HIVE-356
> URL: https://issues.apache.org/jira/browse/HIVE-356
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Serializers/Deserializers
> Affects Versions: 0.3.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-356.1.patch
>
>
> There are some unnecessary Arrays.asList calls in UnionStructObjectInspector. Profiling showed that it takes up to 3% of the CPU.
> We should remove that unnecessary call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-356) Remove Arrays.asList calls
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689552#action_12689552 ]
Namit Jain commented on HIVE-356:
---------------------------------
looks good - can you write some comments in the code that you are handling
object[] and list<object> differently.
+1
upload the patch with more comments and I can commit it
> Remove Arrays.asList calls
> --------------------------
>
> Key: HIVE-356
> URL: https://issues.apache.org/jira/browse/HIVE-356
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Serializers/Deserializers
> Affects Versions: 0.3.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-356.1.patch
>
>
> There are some unnecessary Arrays.asList calls in UnionStructObjectInspector. Profiling showed that it takes up to 3% of the CPU.
> We should remove that unnecessary call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-356) Remove Arrays.asList calls
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-356:
----------------------------
Status: Patch Available (was: Open)
> Remove Arrays.asList calls
> --------------------------
>
> Key: HIVE-356
> URL: https://issues.apache.org/jira/browse/HIVE-356
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Serializers/Deserializers
> Affects Versions: 0.3.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-356.1.patch
>
>
> There are some unnecessary Arrays.asList calls in UnionStructObjectInspector. Profiling showed that it takes up to 3% of the CPU.
> We should remove that unnecessary call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-356) Remove Arrays.asList calls
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689667#action_12689667 ]
Namit Jain commented on HIVE-356:
---------------------------------
looks good
+1
i will commit it if the tests pass
> Remove Arrays.asList calls
> --------------------------
>
> Key: HIVE-356
> URL: https://issues.apache.org/jira/browse/HIVE-356
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Serializers/Deserializers
> Affects Versions: 0.3.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-356.1.patch, HIVE-356.2.patch
>
>
> There are some unnecessary Arrays.asList calls in UnionStructObjectInspector. Profiling showed that it takes up to 3% of the CPU.
> We should remove that unnecessary call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-356) Remove Arrays.asList calls
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-356:
----------------------------
Resolution: Fixed
Fix Version/s: 0.3.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
> Remove Arrays.asList calls
> --------------------------
>
> Key: HIVE-356
> URL: https://issues.apache.org/jira/browse/HIVE-356
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Serializers/Deserializers
> Affects Versions: 0.3.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Fix For: 0.3.0
>
> Attachments: HIVE-356.1.patch, HIVE-356.2.patch
>
>
> There are some unnecessary Arrays.asList calls in UnionStructObjectInspector. Profiling showed that it takes up to 3% of the CPU.
> We should remove that unnecessary call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-356) Remove Arrays.asList calls
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-356:
----------------------------
Attachment: HIVE-356.2.patch
Added comments.
> Remove Arrays.asList calls
> --------------------------
>
> Key: HIVE-356
> URL: https://issues.apache.org/jira/browse/HIVE-356
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Serializers/Deserializers
> Affects Versions: 0.3.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-356.1.patch, HIVE-356.2.patch
>
>
> There are some unnecessary Arrays.asList calls in UnionStructObjectInspector. Profiling showed that it takes up to 3% of the CPU.
> We should remove that unnecessary call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.