You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/11/02 17:23:12 UTC

[jira] [Created] (BOOKKEEPER-452) Rename ClientConfiguration multiplexing_enabled to subscription_connection_sharing_enabled

Ivan Kelly created BOOKKEEPER-452:
-------------------------------------

             Summary: Rename ClientConfiguration multiplexing_enabled to subscription_connection_sharing_enabled
                 Key: BOOKKEEPER-452
                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-452
             Project: Bookkeeper
          Issue Type: Sub-task
            Reporter: Ivan Kelly
            Assignee: Sijie Guo


multiplexing is quite cryptic, and would be hard for someone not associated with hedwig to understand. Something like subscription connection sharing, or subscription channel sharing is clearer. Or even channel sharing alone.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-452) Rename ClientConfiguration multiplexing_enabled to subscription_connection_sharing_enabled

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489697#comment-13489697 ] 

Ivan Kelly commented on BOOKKEEPER-452:
---------------------------------------

Same goes for c++ client config
                
> Rename ClientConfiguration multiplexing_enabled to subscription_connection_sharing_enabled
> ------------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-452
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-452
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: hedwig-client, hedwig-server
>            Reporter: Ivan Kelly
>            Assignee: Sijie Guo
>             Fix For: 4.2.0
>
>
> multiplexing is quite cryptic, and would be hard for someone not associated with hedwig to understand. Something like subscription connection sharing, or subscription channel sharing is clearer. Or even channel sharing alone.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (BOOKKEEPER-452) Rename ClientConfiguration multiplexing_enabled to subscription_connection_sharing_enabled

Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sijie Guo updated BOOKKEEPER-452:
---------------------------------

    Attachment: BOOKKEEPER-452.diff

Attach a file to addressing the rename.
                
> Rename ClientConfiguration multiplexing_enabled to subscription_connection_sharing_enabled
> ------------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-452
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-452
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: hedwig-client, hedwig-server
>            Reporter: Ivan Kelly
>            Assignee: Sijie Guo
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-452.diff
>
>
> multiplexing is quite cryptic, and would be hard for someone not associated with hedwig to understand. Something like subscription connection sharing, or subscription channel sharing is clearer. Or even channel sharing alone.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-452) Rename ClientConfiguration multiplexing_enabled to subscription_connection_sharing_enabled

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492277#comment-13492277 ] 

Hudson commented on BOOKKEEPER-452:
-----------------------------------

Integrated in bookkeeper-trunk #791 (See [https://builds.apache.org/job/bookkeeper-trunk/791/])
    BOOKKEEPER-452: Rename ClientConfiguration multiplexing_enabled to subscription_connection_sharing_enabled (sijie via ivank) (Revision 1406541)

     Result = SUCCESS
ivank : 
Files : 
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/cpp/inc/hedwig/client.h
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/cpp/lib/client.cpp
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/cpp/lib/clientimpl.cpp
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/cpp/test/multiplextest.cpp
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/cpp/test/util.h
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/conf/ClientConfiguration.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigClientImpl.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/client/TestPubSubClient.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/client/netty/TestMultiplexing.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/delivery/TestThrottlingDelivery.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/integration/TestHedwigHub.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/integration/TestHedwigRegion.java

                
> Rename ClientConfiguration multiplexing_enabled to subscription_connection_sharing_enabled
> ------------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-452
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-452
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: hedwig-client, hedwig-server
>            Reporter: Ivan Kelly
>            Assignee: Sijie Guo
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-452.diff
>
>
> multiplexing is quite cryptic, and would be hard for someone not associated with hedwig to understand. Something like subscription connection sharing, or subscription channel sharing is clearer. Or even channel sharing alone.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira