You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/07 02:38:31 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31487: [SPARK-34375][CORE][K8S][TEST] Replaces 'Mockito.initMocks' with 'Mockito.openMocks'

HyukjinKwon commented on a change in pull request #31487:
URL: https://github.com/apache/spark/pull/31487#discussion_r571519710



##########
File path: core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java
##########
@@ -98,7 +98,7 @@ public void tearDown() {
   @Before
   @SuppressWarnings("unchecked")
   public void setUp() throws IOException {
-    MockitoAnnotations.initMocks(this);
+    MockitoAnnotations.openMocks(this);

Review comment:
       Shouldn't we do `openMocks(this).close()`? that's what the docs say.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org