[GitHub] [spark] cloud-fan commented on a change in pull request #23961: [SPARK-27049][SQL] Support handling partition values in the abstraction of file source V2

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #23961: [SPARK-27049][SQL] Support handling partition values in the abstraction of file source V2
URL: https://github.com/apache/spark/pull/23961#discussion_r262375112
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PartitionRecordReader.scala
 ##########
 @@ -29,13 +29,3 @@ class PartitionRecordReader[T](
 
   override def close(): Unit = rowReader.close()
 }
-
-class PartitionRecordReaderWithProject[X, T](
 
 Review comment:
   can we make this class to append partition values?
   
   I feel it's weird to have these 3 methods in `FilePartitionReaderFactory`: `buildReader`, `buildReaderWithPartitionValues` and `buildColumnarReaderWithPartitionValues`. They are not symmetrical.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org