[GitHub] [kvrocks] mapleFU commented on a diff in pull request #1768: Add the support of the BF.INSERT command

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #1768:
URL: https://github.com/apache/kvrocks/pull/1768#discussion_r1331085608


##########
src/commands/cmd_bloom_filter.cc:
##########
@@ -31,7 +31,7 @@ class CommandBFReserve : public Commander {
   Status Parse(const std::vector<std::string> &args) override {
     auto parse_error_rate = ParseFloat<double>(args[2]);
     if (!parse_error_rate) {
-      return {Status::RedisParseErr, errValueIsNotFloat};
+      return {Status::RedisParseErr, "Bad error rate"};

Review Comment:
   We can use some constant here, e.g., in `cmd_bloom_filter.cc`
   
   ```
   namespace {
   errBadErrorRate = "Bad error rate";
   ...
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org