You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by xy...@apache.org on 2021/06/15 02:45:40 UTC

[pulsar] branch master updated: [Fixed] throwable exception not thrown. (#10863)

This is an automated email from the ASF dual-hosted git repository.

xyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new e0988f7  [Fixed]  throwable exception not thrown. (#10863)
e0988f7 is described below

commit e0988f71630df59557356249fb9b5b46e699461c
Author: Qiang Zhao <74...@users.noreply.github.com>
AuthorDate: Tue Jun 15 10:44:57 2021 +0800

    [Fixed]  throwable exception not thrown. (#10863)
    
    Fixes # throwable exception not thrown.
    
    ### Motivation
    
    I found some throwable exception that not thrown, maybe it's a bug.
---
 .../main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
index f6d69a0..ec9de23 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
@@ -1377,7 +1377,7 @@ public abstract class NamespacesBase extends AdminResource {
                             "[{}] Failed to update backlog configuration"
                                     + " for namespace {}: conflicts with retention quota",
                             clientAppId(), namespaceName);
-                    new RestException(Status.PRECONDITION_FAILED,
+                    throw new RestException(Status.PRECONDITION_FAILED,
                             "Backlog Quota exceeds configured retention quota for namespace."
                                     + " Please increase retention quota and retry");
                 }
@@ -1427,7 +1427,7 @@ public abstract class NamespacesBase extends AdminResource {
                 log.warn("[{}] Failed to update retention configuration"
                                 + " for namespace {}: conflicts with backlog quota",
                         clientAppId(), namespaceName);
-                new RestException(Status.PRECONDITION_FAILED,
+                throw new RestException(Status.PRECONDITION_FAILED,
                         "Retention Quota must exceed configured backlog quota for namespace.");
             }
             policies.retention_policies = retention;