You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/13 07:59:34 UTC
[GitHub] [flink-kubernetes-operator] haoxins opened a new pull request, #211: Add jar copy and delete log
haoxins opened a new pull request, #211:
URL: https://github.com/apache/flink-kubernetes-operator/pull/211
Because we delete the jar after submitted the job, it's better to leave some logs for the end users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #211: [FLINK-27600] Add minimal jar coping and deleting logs
Posted by GitBox <gi...@apache.org>.
gyfora merged PR #211:
URL: https://github.com/apache/flink-kubernetes-operator/pull/211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] haoxins commented on a diff in pull request #211: [FLINK-27600] Add minimal jar coping and deleting logs
Posted by GitBox <gi...@apache.org>.
haoxins commented on code in PR #211:
URL: https://github.com/apache/flink-kubernetes-operator/pull/211#discussion_r872938616
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/artifact/FileSystemBasedArtifactFetcher.java:
##########
@@ -39,6 +39,7 @@ public File fetch(String uri, File targetDir) throws Exception {
FileSystem fileSystem = source.getFileSystem();
String fileName = source.getName();
File targetFile = new File(targetDir, fileName);
+ LOG.info("Coping file from {} to {}", source, targetFile);
try (var inputStream = fileSystem.open(source)) {
FileUtils.copyToFile(inputStream, targetFile);
}
Review Comment:
removed and leave the others as `debug` also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] Aitozi commented on a diff in pull request #211: [FLINK-27600] Add minimal jar coping and deleting logs
Posted by GitBox <gi...@apache.org>.
Aitozi commented on code in PR #211:
URL: https://github.com/apache/flink-kubernetes-operator/pull/211#discussion_r872917451
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/artifact/FileSystemBasedArtifactFetcher.java:
##########
@@ -39,6 +39,7 @@ public File fetch(String uri, File targetDir) throws Exception {
FileSystem fileSystem = source.getFileSystem();
String fileName = source.getName();
File targetFile = new File(targetDir, fileName);
+ LOG.info("Coping file from {} to {}", source, targetFile);
try (var inputStream = fileSystem.open(source)) {
FileUtils.copyToFile(inputStream, targetFile);
}
Review Comment:
I think the line below this already log this. It's in `debug` level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org