You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2009/02/10 07:19:00 UTC
[jira] Commented: (THRIFT-236) Structs should be serialized in a
consistent order
[ https://issues.apache.org/jira/browse/THRIFT-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672169#action_12672169 ]
Bryan Duxbury commented on THRIFT-236:
--------------------------------------
Does anyone object to making the Thrift-wide spec for serialization order numeric order? It doesn't have to be done immediately, of course. We should create sub-issues for each language as appropriate.
> Structs should be serialized in a consistent order
> --------------------------------------------------
>
> Key: THRIFT-236
> URL: https://issues.apache.org/jira/browse/THRIFT-236
> Project: Thrift
> Issue Type: Improvement
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.1
>
> Attachments: thrift-236.patch
>
>
> As it stands right now, Ruby generated structs will be serialized in arbitrary order (due to storage of metadata in a hash). This leads to different binary encoding for the same struct values. Ideally, it should be the same for any two serializations of equivalent structs, and between languages if possible.
> The two approaches that seem to make the most sense are in lowest-to-highest field id order, and in IDL-defined order. What do people think of this idea, and which approach would be preferred?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.