You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by hnakamur <gi...@git.apache.org> on 2016/08/26 17:06:21 UTC
[GitHub] trafficserver pull request #930: Add test and doc for proxy config cache sel...
GitHub user hnakamur opened a pull request:
https://github.com/apache/trafficserver/pull/930
Add test and doc for proxy config cache select alternate
I created this pull request after the discussion in the users mailing list.
* [Why is proxy.config.cache.select_alternate undocumented?](https://mail-archives.apache.org/mod_mbox/trafficserver-users/201608.mbox/%3cCAN-DUMSfygPs1eMAnGjvf-WsHhN2zPkt2k6_eUusQ8hWfsBmgw@mail.gmail.com%3e)
* [Re: Why is proxy.config.cache.select_alternate undocumented?](https://mail-archives.apache.org/mod_mbox/trafficserver-users/201608.mbox/%3cDE7328A3-E91A-48FA-842E-8B7F9EC0AF79@gmail.com%3e)
Could you review this?
Thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hnakamur/trafficserver add_test_and_doc_for_proxy_config_cache_select_alternate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/930.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #930
----
commit b1d0908f2606f551fb8fce65b8d6a8242da08370
Author: Hiroaki Nakamura <hn...@gmail.com>
Date: 2016-08-26T02:41:31Z
Update TSQA dependency package names for RHEL/CentOS
commit ed6dc8b2f1855fdffee57616c78a30f2821280b9
Author: Hiroaki Nakamura <hn...@gmail.com>
Date: 2016-08-26T02:44:15Z
Add .gitignore for TSQA
commit a3d523fbe85ed14d0d3c14081875f9c28b50090b
Author: Hiroaki Nakamura <hn...@gmail.com>
Date: 2016-08-26T16:51:24Z
Add test cases for proxy.config.cache.select_alternate
commit fd9bd5f93774a47102a761623ba9a6e85d7b6476
Author: Hiroaki Nakamura <hn...@gmail.com>
Date: 2016-08-26T16:57:55Z
Add document for proxy.config.cache.select_alternate
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #930: Add test and doc for proxy config cache select alt...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/930
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #930: Add test and doc for proxy config cache select alt...
Posted by mingzym <gi...@git.apache.org>.
Github user mingzym commented on the issue:
https://github.com/apache/trafficserver/pull/930
great job!
from your test case, the alternates vary from User-Agent, there is a dedicated config proxy.config.cache.vary_on_user_agent that will control whether we should vary on different User-Agent headers, and I think the cache.select_alternate may result in completely disable the alternate, so as all the 'vary' and 'alts' config options. while vary_on_user_agent may help you vary on AE header and the 'Vary' headers, but not UA. outline here just incase you need it.
well done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #930: Add test and doc for proxy config cache select alt...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/930
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/519/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #930: Add test and doc for proxy config cache select alt...
Posted by mingzym <gi...@git.apache.org>.
Github user mingzym commented on the issue:
https://github.com/apache/trafficserver/pull/930
yeah, sorry for that, forget vary_on_user_agent. :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #930: Add test and doc for proxy config cache select alt...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/930
@jsime Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #930: Add test and doc for proxy config cache select alt...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/930
@jacksontj Can you review the tsqa test portion please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #930: Add test and doc for proxy config cache select alt...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/930
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/623/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #930: Add test and doc for proxy config cache select alt...
Posted by hnakamur <gi...@git.apache.org>.
Github user hnakamur commented on the issue:
https://github.com/apache/trafficserver/pull/930
@mingzym Thanks for your comment.
I searched vary_on_user_agent in the trafficserver source code, but I couldn't find it.
It turned out that proxy.config.cache.vary_on_user_agent was deleted at version 5.3.0: [\[TS-3232\] Remove obsolete proxy.config.vary_on_user_agent configuration - ASF JIRA](https://issues.apache.org/jira/browse/TS-3232)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---