[GitHub] [incubator-pinot] siddharthteotia edited a comment on pull request #5671: Rewrite non-aggregate group by query to distinct query

[GitBox <gi...@apache.org>]

siddharthteotia edited a comment on pull request #5671:
URL: https://github.com/apache/incubator-pinot/pull/5671#issuecomment-656132865


   For completeness, it would be nice to add tests to DistinctQueriesTest file as well.  It has both single column, multi column along with transform function tests for DISTINCT for both intra and inter segment. 
   
   select distinct a from foo
   select distinct a, b from foo
   select distinct add(a, b) from foo
   
   The above are already there. We should add for query rewrite for both identifiers and expressions. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org