You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/02 07:57:41 UTC

[GitHub] [dolphinscheduler] jieguangzhou opened a new pull request, #13074: [Bug] [task retry] Clone retry task Instance missing id field

jieguangzhou opened a new pull request, #13074:
URL: https://github.com/apache/dolphinscheduler/pull/13074

   <!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
   
   ## Purpose of the pull request
   
   close: #13043
   
   The TaskStateEvent will be created if the task `retry interval` is greater than 0.  But we did not clone the taskId for a new task instance, and TaskStateEvent must set the task instance.
   
   
   ## Brief change log
   
   <!--*(for example:)*
   - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
   - *Added dolphinscheduler-dao tests for end-to-end.*
   - *Added CronUtilsTest to verify the change.*
   - *Manually verified the change by testing locally.* -->
   
   (or)
   
   If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] jieguangzhou commented on pull request #13074: [Bug] [task retry] Clone retry task Instance missing id field

Posted by GitBox <gi...@apache.org>.
jieguangzhou commented on PR #13074:
URL: https://github.com/apache/dolphinscheduler/pull/13074#issuecomment-1334895736

   @caishunfeng @ruanwenjun PTAL, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] jieguangzhou closed pull request #13074: [Bug] [task retry] Clone retry task Instance missing id field

Posted by GitBox <gi...@apache.org>.
jieguangzhou closed pull request #13074: [Bug] [task retry] Clone retry task Instance missing id field
URL: https://github.com/apache/dolphinscheduler/pull/13074


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org