You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "g2gps (via GitHub)" <gi...@apache.org> on 2024/05/15 02:32:41 UTC
[PR] benchmarks/ramspeed: Don't expose interrupt control with kernel configuration. [nuttx-apps]
g2gps opened a new pull request, #2393:
URL: https://github.com/apache/nuttx-apps/pull/2393
## Summary
Don't expose interrupt control with kernel configuration.
enter_critical_section and leave_critical_section aren't reliable interfaces to expose in usermode, as they aren't available if CONFIG_IRQCOUNT is enabled.
## Impact
Allows the ramspeed benchmark to be built when both `CONFIG_BUILD_KERNEL` and `CONFIG_IRQCOUNT` are enabled.
## Testing
Litex based board with the above configuration enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] benchmarks/ramspeed: Don't expose interrupt control with kernel configuration. [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2393:
URL: https://github.com/apache/nuttx-apps/pull/2393#discussion_r1601890635
##########
benchmarks/ramspeed/ramspeed_main.c:
##########
@@ -400,7 +404,9 @@ static void memcpy_speed_test(FAR void *dest, FAR const void *src,
if (irq_disable)
{
+ #ifndef CONFIG_BUILD_KERNEL
Review Comment:
CONFIG_BUILD_PROTECTED need the same special handle too
##########
benchmarks/ramspeed/ramspeed_main.c:
##########
@@ -465,7 +473,9 @@ static void memset_speed_test(FAR void *dest, uint8_t value,
if (irq_disable)
{
+ #ifndef CONFIG_BUILD_KERNEL
Review Comment:
should remove all intent
##########
benchmarks/ramspeed/ramspeed_main.c:
##########
@@ -423,7 +429,9 @@ static void memcpy_speed_test(FAR void *dest, FAR const void *src,
if (irq_disable)
{
+ #ifndef CONFIG_BUILD_KERNEL
Review Comment:
how about define leave_critical_section to empty macro in case of protected/kernel build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] benchmarks/ramspeed: Don't expose interrupt control with kernel configuration. [nuttx-apps]
Posted by "g2gps (via GitHub)" <gi...@apache.org>.
g2gps commented on PR #2393:
URL: https://github.com/apache/nuttx-apps/pull/2393#issuecomment-2121469377
Should be a bit clearer, and covers CONFIG_BUILD_PROTECTED.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] benchmarks/ramspeed: Don't expose interrupt control with kernel configuration. [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2393:
URL: https://github.com/apache/nuttx-apps/pull/2393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org