You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Jing Zhao (JIRA)" <ji...@apache.org> on 2014/04/23 19:53:18 UTC

[jira] [Commented] (HDFS-6276) Remove unnecessary conditions and null check

    [ https://issues.apache.org/jira/browse/HDFS-6276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978535#comment-13978535 ] 

Jing Zhao commented on HDFS-6276:
---------------------------------

The patch looks pretty good. One minor is that in INodeFile#cleanSubtree, we also need to change "if (snapshot == CURRENT_STATE_ID && priorSnapshotId == NO_SNAPSHOT_ID) {" to "if (snapshot == CURRENT_STATE_ID) {". Other than this +1.

> Remove unnecessary conditions and null check
> --------------------------------------------
>
>                 Key: HDFS-6276
>                 URL: https://issues.apache.org/jira/browse/HDFS-6276
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>         Attachments: HDFS-6276.patch
>
>
> The code has many places where null check and other condition checks are unnecessary.



--
This message was sent by Atlassian JIRA
(v6.2#6252)