You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "laurentgo (via GitHub)" <gi...@apache.org> on 2024/07/11 16:30:03 UTC

[PR] GH-43217: [Java] Remove flight-core shaded jars [arrow]

laurentgo opened a new pull request, #43224:
URL: https://github.com/apache/arrow/pull/43224

   ### Rationale for this change
   
   Remove extra jars generated by `flight-core` modules:
   - they do not seem to be used by the project internally and does not seem to satisfy some external purpose as well
   - they are not compatible with JPMS
   
   ### Are these changes tested?
   
   CI/CD
   
   ### Are there any user-facing changes?
   
   Several extras jars attached to `org.apache.arrow:flight-core` artifact will stop being published to Apache Maven Repository/Maven Central.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-43217: [Java] Remove flight-core shaded jars [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43224:
URL: https://github.com/apache/arrow/pull/43224#issuecomment-2223416492

   Revision: 95209c258d06fcb541a2bd253d77ae1d3ae4b36d
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-382cf2fea3](https://github.com/ursacomputing/crossbow/branches/all?query=actions-382cf2fea3)
   
   |Task|Status|
   |----|------|
   |java-jars|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-382cf2fea3-github-java-jars)](https://github.com/ursacomputing/crossbow/actions/runs/9895351982/job/27335031159)|
   |test-conda-python-3.10-spark-v3.5.0|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-382cf2fea3-github-test-conda-python-3.10-spark-v3.5.0)](https://github.com/ursacomputing/crossbow/actions/runs/9895351912/job/27335029266)|
   |test-conda-python-3.11-spark-master|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-382cf2fea3-github-test-conda-python-3.11-spark-master)](https://github.com/ursacomputing/crossbow/actions/runs/9895351905/job/27335029206)|
   |test-conda-python-3.8-spark-v3.5.0|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-382cf2fea3-github-test-conda-python-3.8-spark-v3.5.0)](https://github.com/ursacomputing/crossbow/actions/runs/9895351989/job/27335029684)|
   |verify-rc-source-java-linux-almalinux-8-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-382cf2fea3-github-verify-rc-source-java-linux-almalinux-8-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/9895351910/job/27335029197)|
   |verify-rc-source-java-linux-conda-latest-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-382cf2fea3-github-verify-rc-source-java-linux-conda-latest-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/9895352021/job/27335029638)|
   |verify-rc-source-java-linux-ubuntu-20.04-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-382cf2fea3-github-verify-rc-source-java-linux-ubuntu-20.04-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/9895352001/job/27335029672)|
   |verify-rc-source-java-linux-ubuntu-22.04-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-382cf2fea3-github-verify-rc-source-java-linux-ubuntu-22.04-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/9895352061/job/27335030180)|
   |verify-rc-source-java-macos-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-382cf2fea3-github-verify-rc-source-java-macos-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/9895352130/job/27335030486)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-43217: [Java] Remove flight-core shaded jars [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43224:
URL: https://github.com/apache/arrow/pull/43224#issuecomment-2223381617

   :warning: GitHub issue #43217 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-43217: [Java] Remove flight-core shaded jars [arrow]

Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo commented on PR #43224:
URL: https://github.com/apache/arrow/pull/43224#issuecomment-2228863462

   > No concerns as I don't see a reason to use these externally. May as well just delete the shade tasks instead of comment them out though.
   
   Didn't realize I left them commented out instead of removing, will post an update quickly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-43217: [Java] Remove flight-core shaded jars [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #43224:
URL: https://github.com/apache/arrow/pull/43224#issuecomment-2230076275

   After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7d542e4287d43e241743de963f9d93a90906624d.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/27491004377) has more details. It also includes information about 38 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-43217: [Java] Remove flight-core shaded jars [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43224:
URL: https://github.com/apache/arrow/pull/43224#issuecomment-2223940598

   Revision: 8d7edefc8bf1baf4249ed89bb963fab657ac17fd
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-3c82cb02dc](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3c82cb02dc)
   
   |Task|Status|
   |----|------|
   |java-jars|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-3c82cb02dc-github-java-jars)](https://github.com/ursacomputing/crossbow/actions/runs/9898486401/job/27345401759)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-43217: [Java] Remove flight-core shaded jars [arrow]

Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on PR #43224:
URL: https://github.com/apache/arrow/pull/43224#issuecomment-2228464091

   No concerns as I don't see a reason to use these externally. May as well just delete the shade tasks instead of comment them out though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-43217: [Java] Remove flight-core shaded jars [arrow]

Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on PR #43224:
URL: https://github.com/apache/arrow/pull/43224#issuecomment-2244991742

   @github-actions crossbow submit java-jars


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-43217: [Java] Remove flight-core shaded jars [arrow]

Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin merged PR #43224:
URL: https://github.com/apache/arrow/pull/43224


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-43217: [Java] Remove flight-core shaded jars [arrow]

Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo commented on PR #43224:
URL: https://github.com/apache/arrow/pull/43224#issuecomment-2223937788

   @github-actions crossbow submit java-jars


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-43217: [Java] Remove flight-core shaded jars [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43224:
URL: https://github.com/apache/arrow/pull/43224#issuecomment-2244997559

   Revision: 796a3eee1bf748913caec13da63436415fa58d50
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-809f60bac2](https://github.com/ursacomputing/crossbow/branches/all?query=actions-809f60bac2)
   
   |Task|Status|
   |----|------|
   |java-jars|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-809f60bac2-github-java-jars)](https://github.com/ursacomputing/crossbow/actions/runs/10058156361/job/27800618540)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-43217: [Java] Remove flight-core shaded jars [arrow]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #43224:
URL: https://github.com/apache/arrow/pull/43224#issuecomment-2227925283

   @danepitkin @jduo any concerns here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-43217: [Java] Remove flight-core shaded jars [arrow]

Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo commented on PR #43224:
URL: https://github.com/apache/arrow/pull/43224#issuecomment-2223411486

   @github-actions crossbow submit -g java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org