You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Jared Cantwell (JIRA)" <ji...@apache.org> on 2011/06/15 21:00:49 UTC
[jira] [Created] (ZOOKEEPER-1096) Leader communication should
listen on specified IP, not wildcard address
Leader communication should listen on specified IP, not wildcard address
------------------------------------------------------------------------
Key: ZOOKEEPER-1096
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
Project: ZooKeeper
Issue Type: Improvement
Components: server
Affects Versions: 3.3.3, 3.4.0
Reporter: Jared Cantwell
Priority: Minor
Server should specify the local address that is used for leader communication (and not use the default of listening on all interfaces). This is similar to the clientPortAddress parameter that was added a year ago. After reviewing the code, we can't think of a reason why only the port would be used with the wildcard interface, when servers are already connecting specifically to that interface anyway.
I have submitted a patch, but it does not account for all leader election algorithms.
Probably should have an option to toggle this, for backwards compatibility, although it seems like it would be a bug if this change broke things.
There is some more information about making it an option here:
http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=H2+7Gnj_4p28hgCXjh345HiyN@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1096) Leader communication should
listen on specified IP, not wildcard address
Posted by "Thomas Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108063#comment-13108063 ]
Thomas Koch commented on ZOOKEEPER-1096:
----------------------------------------
Could you please upload the patch to https://reviews.apache.org/r/new/ for review?
> Leader communication should listen on specified IP, not wildcard address
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Jared Cantwell
> Assignee: Jared Cantwell
> Priority: Minor
> Attachments: ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch
>
>
> Server should specify the local address that is used for leader communication (and not use the default of listening on all interfaces). This is similar to the clientPortAddress parameter that was added a year ago. After reviewing the code, we can't think of a reason why only the port would be used with the wildcard interface, when servers are already connecting specifically to that interface anyway.
> I have submitted a patch, but it does not account for all leader election algorithms.
> Probably should have an option to toggle this, for backwards compatibility, although it seems like it would be a bug if this change broke things.
> There is some more information about making it an option here:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=H2+7Gnj_4p28hgCXjh345HiyN@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1096) Leader communication should
listen on specified IP, not wildcard address
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057222#comment-13057222 ]
Hadoop QA commented on ZOOKEEPER-1096:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482704/ZOOKEEPER-1096.patch
against trunk revision 1140017.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/355//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/355//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/355//console
This message is automatically generated.
> Leader communication should listen on specified IP, not wildcard address
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Jared Cantwell
> Assignee: Jared Cantwell
> Priority: Minor
> Attachments: ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch
>
>
> Server should specify the local address that is used for leader communication (and not use the default of listening on all interfaces). This is similar to the clientPortAddress parameter that was added a year ago. After reviewing the code, we can't think of a reason why only the port would be used with the wildcard interface, when servers are already connecting specifically to that interface anyway.
> I have submitted a patch, but it does not account for all leader election algorithms.
> Probably should have an option to toggle this, for backwards compatibility, although it seems like it would be a bug if this change broke things.
> There is some more information about making it an option here:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=H2+7Gnj_4p28hgCXjh345HiyN@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1096) Leader communication should
listen on specified IP, not wildcard address
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096322#comment-13096322 ]
Hadoop QA commented on ZOOKEEPER-1096:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482704/ZOOKEEPER-1096.patch
against trunk revision 1164710.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/492//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/492//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/492//console
This message is automatically generated.
> Leader communication should listen on specified IP, not wildcard address
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Jared Cantwell
> Assignee: Jared Cantwell
> Priority: Minor
> Attachments: ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch
>
>
> Server should specify the local address that is used for leader communication (and not use the default of listening on all interfaces). This is similar to the clientPortAddress parameter that was added a year ago. After reviewing the code, we can't think of a reason why only the port would be used with the wildcard interface, when servers are already connecting specifically to that interface anyway.
> I have submitted a patch, but it does not account for all leader election algorithms.
> Probably should have an option to toggle this, for backwards compatibility, although it seems like it would be a bug if this change broke things.
> There is some more information about making it an option here:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=H2+7Gnj_4p28hgCXjh345HiyN@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1096) Leader communication should
listen on specified IP, not wildcard address
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050022#comment-13050022 ]
Hadoop QA commented on ZOOKEEPER-1096:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482704/ZOOKEEPER-1096.patch
against trunk revision 1135515.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/319//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/319//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/319//console
This message is automatically generated.
> Leader communication should listen on specified IP, not wildcard address
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Jared Cantwell
> Assignee: Jared Cantwell
> Priority: Minor
> Attachments: ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch
>
>
> Server should specify the local address that is used for leader communication (and not use the default of listening on all interfaces). This is similar to the clientPortAddress parameter that was added a year ago. After reviewing the code, we can't think of a reason why only the port would be used with the wildcard interface, when servers are already connecting specifically to that interface anyway.
> I have submitted a patch, but it does not account for all leader election algorithms.
> Probably should have an option to toggle this, for backwards compatibility, although it seems like it would be a bug if this change broke things.
> There is some more information about making it an option here:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=H2+7Gnj_4p28hgCXjh345HiyN@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1096) Leader communication should
listen on specified IP, not wildcard address
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050006#comment-13050006 ]
Hadoop QA commented on ZOOKEEPER-1096:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482704/ZOOKEEPER-1096.patch
against trunk revision 1135515.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/318//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/318//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/318//console
This message is automatically generated.
> Leader communication should listen on specified IP, not wildcard address
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Jared Cantwell
> Assignee: Jared Cantwell
> Priority: Minor
> Attachments: ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch
>
>
> Server should specify the local address that is used for leader communication (and not use the default of listening on all interfaces). This is similar to the clientPortAddress parameter that was added a year ago. After reviewing the code, we can't think of a reason why only the port would be used with the wildcard interface, when servers are already connecting specifically to that interface anyway.
> I have submitted a patch, but it does not account for all leader election algorithms.
> Probably should have an option to toggle this, for backwards compatibility, although it seems like it would be a bug if this change broke things.
> There is some more information about making it an option here:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=H2+7Gnj_4p28hgCXjh345HiyN@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1096) Leader communication should
listen on specified IP, not wildcard address
Posted by "Jared Cantwell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jared Cantwell updated ZOOKEEPER-1096:
--------------------------------------
Attachment: ZOOKEEPER-1096.patch
> Leader communication should listen on specified IP, not wildcard address
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Jared Cantwell
> Priority: Minor
> Attachments: ZOOKEEPER-1096.patch
>
>
> Server should specify the local address that is used for leader communication (and not use the default of listening on all interfaces). This is similar to the clientPortAddress parameter that was added a year ago. After reviewing the code, we can't think of a reason why only the port would be used with the wildcard interface, when servers are already connecting specifically to that interface anyway.
> I have submitted a patch, but it does not account for all leader election algorithms.
> Probably should have an option to toggle this, for backwards compatibility, although it seems like it would be a bug if this change broke things.
> There is some more information about making it an option here:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=H2+7Gnj_4p28hgCXjh345HiyN@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1096) Leader communication should
listen on specified IP, not wildcard address
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049982#comment-13049982 ]
Patrick Hunt commented on ZOOKEEPER-1096:
-----------------------------------------
bq. Probably should have an option to toggle this, for backwards compatibility, although it seems like it would be a bug if this change broke things.
I agree on both counts.
> Leader communication should listen on specified IP, not wildcard address
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Jared Cantwell
> Assignee: Jared Cantwell
> Priority: Minor
> Attachments: ZOOKEEPER-1096.patch
>
>
> Server should specify the local address that is used for leader communication (and not use the default of listening on all interfaces). This is similar to the clientPortAddress parameter that was added a year ago. After reviewing the code, we can't think of a reason why only the port would be used with the wildcard interface, when servers are already connecting specifically to that interface anyway.
> I have submitted a patch, but it does not account for all leader election algorithms.
> Probably should have an option to toggle this, for backwards compatibility, although it seems like it would be a bug if this change broke things.
> There is some more information about making it an option here:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=H2+7Gnj_4p28hgCXjh345HiyN@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1096) Leader communication should
listen on specified IP, not wildcard address
Posted by "Jared Cantwell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jared Cantwell updated ZOOKEEPER-1096:
--------------------------------------
Attachment: ZOOKEEPER-1096.patch
Fixed some prefixes.
> Leader communication should listen on specified IP, not wildcard address
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Jared Cantwell
> Assignee: Jared Cantwell
> Priority: Minor
> Attachments: ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch
>
>
> Server should specify the local address that is used for leader communication (and not use the default of listening on all interfaces). This is similar to the clientPortAddress parameter that was added a year ago. After reviewing the code, we can't think of a reason why only the port would be used with the wildcard interface, when servers are already connecting specifically to that interface anyway.
> I have submitted a patch, but it does not account for all leader election algorithms.
> Probably should have an option to toggle this, for backwards compatibility, although it seems like it would be a bug if this change broke things.
> There is some more information about making it an option here:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=H2+7Gnj_4p28hgCXjh345HiyN@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1096) Leader communication should
listen on specified IP, not wildcard address
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-1096:
---------------------------------------
Assignee: Jared Cantwell
> Leader communication should listen on specified IP, not wildcard address
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Jared Cantwell
> Assignee: Jared Cantwell
> Priority: Minor
> Attachments: ZOOKEEPER-1096.patch
>
>
> Server should specify the local address that is used for leader communication (and not use the default of listening on all interfaces). This is similar to the clientPortAddress parameter that was added a year ago. After reviewing the code, we can't think of a reason why only the port would be used with the wildcard interface, when servers are already connecting specifically to that interface anyway.
> I have submitted a patch, but it does not account for all leader election algorithms.
> Probably should have an option to toggle this, for backwards compatibility, although it seems like it would be a bug if this change broke things.
> There is some more information about making it an option here:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=H2+7Gnj_4p28hgCXjh345HiyN@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1096) Leader communication should
listen on specified IP, not wildcard address
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049980#comment-13049980 ]
Patrick Hunt commented on ZOOKEEPER-1096:
-----------------------------------------
with git use "--no-prefix" when creating the patch.
> Leader communication should listen on specified IP, not wildcard address
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Jared Cantwell
> Assignee: Jared Cantwell
> Priority: Minor
> Attachments: ZOOKEEPER-1096.patch
>
>
> Server should specify the local address that is used for leader communication (and not use the default of listening on all interfaces). This is similar to the clientPortAddress parameter that was added a year ago. After reviewing the code, we can't think of a reason why only the port would be used with the wildcard interface, when servers are already connecting specifically to that interface anyway.
> I have submitted a patch, but it does not account for all leader election algorithms.
> Probably should have an option to toggle this, for backwards compatibility, although it seems like it would be a bug if this change broke things.
> There is some more information about making it an option here:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=H2+7Gnj_4p28hgCXjh345HiyN@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1096) Leader communication should
listen on specified IP, not wildcard address
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049971#comment-13049971 ]
Hadoop QA commented on ZOOKEEPER-1096:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482702/ZOOKEEPER-1096.patch
against trunk revision 1135515.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/317//console
This message is automatically generated.
> Leader communication should listen on specified IP, not wildcard address
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Jared Cantwell
> Priority: Minor
> Attachments: ZOOKEEPER-1096.patch
>
>
> Server should specify the local address that is used for leader communication (and not use the default of listening on all interfaces). This is similar to the clientPortAddress parameter that was added a year ago. After reviewing the code, we can't think of a reason why only the port would be used with the wildcard interface, when servers are already connecting specifically to that interface anyway.
> I have submitted a patch, but it does not account for all leader election algorithms.
> Probably should have an option to toggle this, for backwards compatibility, although it seems like it would be a bug if this change broke things.
> There is some more information about making it an option here:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=H2+7Gnj_4p28hgCXjh345HiyN@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira