[jira] [Resolved] (LUCENE-5301) All PackedInts APIs should share a common interface for random-access reads

["Adrien Grand (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrien Grand resolved LUCENE-5301.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 4.6

> All PackedInts APIs should share a common interface for random-access reads
> ---------------------------------------------------------------------------
>
>                 Key: LUCENE-5301
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5301
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>             Fix For: 4.6
>
>         Attachments: LUCENE-5301.patch, LUCENE-5301.patch
>
>
> It would be convenient if all PackedInts had a super-class with the {{long get(long index)}} method. Maybe this super-class could even be NumericDocValues so that doc values formats don't need to wrap eg. BlockPackedReader into this kind of construct:
> {code}
>         final BlockPackedReader reader = new BlockPackedReader(data, entry.packedIntsVersion, entry.blockSize, entry.count, true);
>         return new LongNumericDocValues() {
>           @Override
>           public long get(long id) {
>             return reader.get(id);
>           }
>         };
> {code}
> Instead, they could just
> {code}
>         return new BlockPackedReader(data, entry.packedIntsVersion, entry.blockSize, entry.count, true);
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org