You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/02/15 08:02:59 UTC
Review Request: SQOOP-884 Sqoop2: Disable interactive client commands in
batch mode
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9465/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've enhanced the client to keep track whether it's being executed in batch or interactive mode. Usage of pure interactive commands (update, create, clone) in batch mode will throw an exception rather than "freezing" the program by waiting on input that might never come.
This addresses bug SQOOP-884.
https://issues.apache.org/jira/browse/SQOOP-884
Diffs
-----
client/src/main/java/org/apache/sqoop/client/core/ClientError.java fd3b97d80491eeda6b7fabef11dcd5878729bbf5
client/src/main/java/org/apache/sqoop/client/core/Environment.java c9e4e2a5bea8642cfe705d0771a06ab536cbf463
client/src/main/java/org/apache/sqoop/client/shell/CloneCommand.java a127d61661113ef0ede865b20d20adcf65dc3af1
client/src/main/java/org/apache/sqoop/client/shell/CreateCommand.java 6cd2ff5e3e2f77f4f1e34d058cf5b3720bb7887c
client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 9fb5f036a5ba7c76d0f948af08ac6f3c144ffc77
client/src/main/java/org/apache/sqoop/client/shell/UpdateCommand.java fcf8862f23fb8cad276a6c74278db515b0604d70
Diff: https://reviews.apache.org/r/9465/diff/
Testing
-------
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-884 Sqoop2: Disable interactive client commands in
batch mode
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9465/#review16957
-----------------------------------------------------------
Ship it!
Ship It!
- Cheolsoo Park
On Feb. 15, 2013, 7:02 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9465/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2013, 7:02 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've enhanced the client to keep track whether it's being executed in batch or interactive mode. Usage of pure interactive commands (update, create, clone) in batch mode will throw an exception rather than "freezing" the program by waiting on input that might never come.
>
>
> This addresses bug SQOOP-884.
> https://issues.apache.org/jira/browse/SQOOP-884
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/ClientError.java fd3b97d80491eeda6b7fabef11dcd5878729bbf5
> client/src/main/java/org/apache/sqoop/client/core/Environment.java c9e4e2a5bea8642cfe705d0771a06ab536cbf463
> client/src/main/java/org/apache/sqoop/client/shell/CloneCommand.java a127d61661113ef0ede865b20d20adcf65dc3af1
> client/src/main/java/org/apache/sqoop/client/shell/CreateCommand.java 6cd2ff5e3e2f77f4f1e34d058cf5b3720bb7887c
> client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 9fb5f036a5ba7c76d0f948af08ac6f3c144ffc77
> client/src/main/java/org/apache/sqoop/client/shell/UpdateCommand.java fcf8862f23fb8cad276a6c74278db515b0604d70
>
> Diff: https://reviews.apache.org/r/9465/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>