You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/06 12:03:41 UTC
[GitHub] [spark] ulysses-you opened a new pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
ulysses-you opened a new pull request #34820:
URL: https://github.com/apache/spark/pull/34820
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Pass `MapOutputStatistics` to `ShuffledRowRDD` in AQE code path so we can do sort according to the origin reduce partition size.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The coalesced partition can contain several reduce partitions. The preferred locations of the RDD partition should be the biggest reduce partition before coalesced.
So it can get a better data locality and reduce the network traffic.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Added test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34820:
URL: https://github.com/apache/spark/pull/34820#issuecomment-986742490
**[Test build #145953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145953/testReport)** for PR 34820 at commit [`64890e2`](https://github.com/apache/spark/commit/64890e2eb2799fc783de7138054fcf08eff85603).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #34820:
URL: https://github.com/apache/spark/pull/34820#issuecomment-987760901
thank you @maryannxue for the explanation, I see your point now.
It's really hard to give the number of this change. In our production, the `advisoryPartitionSizeInBytes` value of writing job's last stage is always bigger than the default value, e.g. 512MB. The origin partitions before coalesced can also be big and so are the blocks. So I think it's more likely to take the benifits. But yes, I cann't say the number here..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #34820:
URL: https://github.com/apache/spark/pull/34820#issuecomment-987528689
@maryannxue `CoalescedPartitionSpec` only cares about the reduce partition so the max length need to sort is the shuffle partition number, so I think the added complexity is no harm.
To be conservative, I do a benchmark using the added complexity with 100000 shuffle partitions:
```scala
val shufflePartitions = 100000
val rand = new Random(0)
val bytesByPartitionId = Seq.tabulate(shufflePartitions)(i => rand.nextLong().abs).toArray
var previous = 0
var next = 0
val partitions = new ArrayBuffer[(Int, Int)]()
while (next < shufflePartitions) {
next = next + rand.nextInt(100)
partitions.append((previous, next.min(shufflePartitions - 1)))
previous = next
}
val start = System.nanoTime()
partitions.foreach { case (start, end) =>
(start until end)
.map(index => (index, bytesByPartitionId(index)))
.sortBy(_._2)(implicitly[Ordering[Long]].reverse)
}
println((System.nanoTime() - start) / 1000000)
```
It takes 73ms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34820:
URL: https://github.com/apache/spark/pull/34820#issuecomment-986815472
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50428/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34820:
URL: https://github.com/apache/spark/pull/34820#issuecomment-986841807
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50428/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34820:
URL: https://github.com/apache/spark/pull/34820#issuecomment-986841807
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50428/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34820:
URL: https://github.com/apache/spark/pull/34820#issuecomment-986983501
**[Test build #145953 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145953/testReport)** for PR 34820 at commit [`64890e2`](https://github.com/apache/spark/commit/64890e2eb2799fc783de7138054fcf08eff85603).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #34820:
URL: https://github.com/apache/spark/pull/34820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34820:
URL: https://github.com/apache/spark/pull/34820#issuecomment-986779283
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50428/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34820:
URL: https://github.com/apache/spark/pull/34820#issuecomment-987006851
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145953/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34820:
URL: https://github.com/apache/spark/pull/34820#issuecomment-987006851
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145953/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #34820:
URL: https://github.com/apache/spark/pull/34820#issuecomment-1071891792
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34820:
URL: https://github.com/apache/spark/pull/34820#issuecomment-986742490
**[Test build #145953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145953/testReport)** for PR 34820 at commit [`64890e2`](https://github.com/apache/spark/commit/64890e2eb2799fc783de7138054fcf08eff85603).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maryannxue commented on pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
Posted by GitBox <gi...@apache.org>.
maryannxue commented on pull request #34820:
URL: https://github.com/apache/spark/pull/34820#issuecomment-987537201
@ulysses-you My question was: did we see any real benefit from this change in the benchmark? Other than the extra computation, the "added complexity" also means the future code maintenance effort. If we can't prove any real benefit, we should keep the logic simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #34820:
URL: https://github.com/apache/spark/pull/34820#issuecomment-986795949
cc @cloud-fan @maryannxue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maryannxue commented on pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
Posted by GitBox <gi...@apache.org>.
maryannxue commented on pull request #34820:
URL: https://github.com/apache/spark/pull/34820#issuecomment-987282101
Any real numbers for the added complexity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #34820: [SPARK-37559][SQL] ShuffledRowRDD get preferred locations order by reduce size
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #34820:
URL: https://github.com/apache/spark/pull/34820#issuecomment-1071891792
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org