[jira] [Created] (IMPALA-5801) Clean up codegen GetType() interface

["Tim Armstrong (JIRA)" <ji...@apache.org>]

Tim Armstrong created IMPALA-5801:
-------------------------------------

             Summary: Clean up codegen GetType() interface
                 Key: IMPALA-5801
                 URL: https://issues.apache.org/jira/browse/IMPALA-5801
             Project: IMPALA
          Issue Type: Improvement
          Components: Backend
            Reporter: Tim Armstrong
            Priority: Minor


The naming and usage of the two LlvmCodegen::GetType() methods is confusing. They seem to serve multiple distinct purposes:
* GetType(const string&) is simple enough - it looks up a predeclared type by name.
* GetType(ColumnType) returns the internal representation of a column type. At some callsites it is used for this purpose. We should probably rename to GetInternalRepresentation() or something like that.
* GetType(ColumnType) is also used as a convenience function to get a specific integer type, e.g. GetType(TYPE_INT). Those callsites should probably just call codegen->int_type() instead of using the general-purpose GetType() function.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)