You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "zaynt4606 (via GitHub)" <gi...@apache.org> on 2024/12/09 03:54:00 UTC
[PR] [CELEBORN-1767] Fix occasional errors in UT when creating workers [celeborn]
zaynt4606 opened a new pull request, #2984:
URL: https://github.com/apache/celeborn/pull/2984
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Remove assert in setupWorker for UT which might make ut fail directly.

### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1767] Fix occasional errors in UT when creating workers [celeborn]
Posted by "zaynt4606 (via GitHub)" <gi...@apache.org>.
zaynt4606 commented on code in PR #2984:
URL: https://github.com/apache/celeborn/pull/2984#discussion_r1877710847
##########
worker/src/test/scala/org/apache/celeborn/service/deploy/MiniClusterFeature.scala:
##########
@@ -226,12 +226,14 @@ trait MiniClusterFeature extends Logging {
{
if (workers(i) == null) {
throw new IllegalStateException(s"worker $i hasn't been initialized")
- } else {
+ } else if (!workerInfos.contains(workers(i))) {
workerInfos.put(workers(i), threads(i))
}
+ if (!workers(i).registered.get()) {
+ throw new IllegalStateException(s"worker $i hasn't been registered")
+ }
}
}
- workerInfos.foreach { case (worker, _) => assert(worker.registered.get()) }
allWorkersStarted = true
} catch {
case ex: Throwable =>
Review Comment:
The wait logic is here~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1767] Fix occasional errors in UT when creating workers [celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX closed pull request #2984: [CELEBORN-1767] Fix occasional errors in UT when creating workers
URL: https://github.com/apache/celeborn/pull/2984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1767] Fix occasional errors in UT when creating workers [celeborn]
Posted by "zaynt4606 (via GitHub)" <gi...@apache.org>.
zaynt4606 commented on PR #2984:
URL: https://github.com/apache/celeborn/pull/2984#issuecomment-2530990281
> This pr seems will make UT fail faster, why can it fix occasional UT failures?
If `worker.registered.get()` is false, This pr will wait for the worker to register While assertionError will make the UT job aborted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1767] Fix occasional errors in UT when creating workers [celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #2984:
URL: https://github.com/apache/celeborn/pull/2984#issuecomment-2530955092
This pr seems will make UT fail faster, why can it fix occasional UT failures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org