You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/05 02:33:50 UTC
[GitHub] [airflow] mattluudo opened a new pull request #11270: [AIRFLOW-10186] Move Tips & Tricks for Oracle shops should be moved to Airflow Docs
mattluudo opened a new pull request #11270:
URL: https://github.com/apache/airflow/pull/11270
Fixed broken Oracle link
Added "Host" Argument and provided examples
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11270: [AIRFLOW-10186] Move Tips & Tricks for Oracle shops should be moved to Airflow Docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11270:
URL: https://github.com/apache/airflow/pull/11270#issuecomment-703383437
The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).
You can checks the status of those images in [The workflow run](https://github.com/apache/airflow/actions/runs/288682134)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mattluudo closed pull request #11270: [AIRFLOW-10186] Move Tips & Tricks for Oracle shops should be moved to Airflow Docs
Posted by GitBox <gi...@apache.org>.
mattluudo closed pull request #11270:
URL: https://github.com/apache/airflow/pull/11270
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mattluudo commented on pull request #11270: [AIRFLOW-10186] Move Tips & Tricks for Oracle shops should be moved to Airflow Docs
Posted by GitBox <gi...@apache.org>.
mattluudo commented on pull request #11270:
URL: https://github.com/apache/airflow/pull/11270#issuecomment-703367324
@potiuk @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11270: [AIRFLOW-10186] Move Tips & Tricks for Oracle shops should be moved to Airflow Docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11270:
URL: https://github.com/apache/airflow/pull/11270#issuecomment-703367367
[The Build Workflow run](https://github.com/apache/airflow/actions/runs/288603830) is cancelling this PR. The job has been cancelled by another workflow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11270: [AIRFLOW-10186] Move Tips & Tricks for Oracle shops should be moved to Airflow Docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11270:
URL: https://github.com/apache/airflow/pull/11270#issuecomment-703364847
The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).
You can checks the status of those images in [The workflow run](https://github.com/apache/airflow/actions/runs/288603830)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11270: [AIRFLOW-10186] Move Tips & Tricks for Oracle shops should be moved to Airflow Docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11270:
URL: https://github.com/apache/airflow/pull/11270#issuecomment-703383716
The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).
You can checks the status of those images in [The workflow run](https://github.com/apache/airflow/actions/runs/288683178)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11270: [AIRFLOW-10186] Move Tips & Tricks for Oracle shops should be moved to Airflow Docs
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #11270:
URL: https://github.com/apache/airflow/pull/11270#issuecomment-703364786
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org