You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "tuhaihe (via GitHub)" <gi...@apache.org> on 2026/02/05 10:28:24 UTC

[PR] ASF: Update Apache compliance and branding migration [cloudberry-pxf]

tuhaihe opened a new pull request, #55:
URL: https://github.com/apache/cloudberry-pxf/pull/55

   This commit implements comprehensive changes to align the project with Apache Software Foundation incubation requirements and complete the migration from Greenplum to Apache Cloudberry branding.
   
   - Add DISCLAIMER file as required for Apache incubating projects
   - Update LICENSE file with comprehensive list of 245 files containing Apache License headers, organized by module (FDW, External Table, Server, Documentation, CI/Test templates)
   - Add Apache License headers to GitHub workflow files
   - Update CONTRIBUTING.md with Apache project contribution guidelines
   
   - Update README.md with Apache Cloudberry branding and simplified content
   - Update documentation templates in docs/content/ to use Cloudberry
   - Update package specifications and installation scripts:
     * Rename package from pxf-gpX to cloudberry-pxf
     * Update installation paths to /usr/local/cloudberry-pxf-[VERSION]
     * Remove legacy pxf-gp7.spec and pxf-cbdb1.spec files
     * Update DEBIAN package control files with new naming
   - Update automation and testing documentation
   - Migrate server scripts and Java components references
   
   - Standardize package configuration based on cloudberry-pxf.spec
   - Update CI/CD workflows with proper Apache licensing
   - Clean up legacy CI documentation (remove ci/README.md)
   - Update build system references in Makefile
   - Enhance installation scripts to support both Cloudberry 2.0 and 2.1+
   
   - Add transition guide for Cloudberry migration
   - Update all user-facing documentation with correct branding
   - Simplify README.md focusing on essential information
   - Update book configuration for documentation generation
   
   This change ensures full compliance with Apache incubation requirements while completing the transition to Apache Cloudberry ecosystem.
   
   <!--Thank you for contributing! -->
   
   <!--In case of an existing issue or discussions, please reference it-->
   closes: #ISSUE_Number
   <!--Remove this section if no corresponding issue.-->
   
   ---
   
   ## Change logs
   
   > Describe your change clearly, including what problem is being solved or what document is being added or updated.
   
   ## Contributor's checklist
   
   Here are some reminders before you submit your pull request:
   
   * Make sure that your Pull Request has a clear title and commit message. You can take the [Git commit template](https://github.com/apache/cloudberry/blob/main/.gitmessage) as a reference.
   * Learn the [code contribution](https://cloudberry.apache.org/contribute/code) and [doc contribution](https://cloudberry.apache.org/contribute/doc) guides for better collaboration.
   * Make sure that CICD workflow is successful.
   * List your communications in the [GitHub Issues](https://github.com/apache/cloudberry-pxf/issues) or [Discussions](https://github.com/apache/cloudberry/discussions) (if has or needed).
   * Feel free to ask for the [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers) or other people to help review and approve.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org


Re: [PR] ASF: Update Apache compliance and branding migration [cloudberry-pxf]

Posted by "ostinru (via GitHub)" <gi...@apache.org>.
ostinru commented on code in PR #55:
URL: https://github.com/apache/cloudberry-pxf/pull/55#discussion_r2772726954


##########
README.md:
##########
@@ -78,43 +74,35 @@ To build PXF, you must have:
     go install github.com/onsi/ginkgo/ginkgo@latest
     ```
 
-5. cURL (7.29 or later):
-
-    To install cURL devel package on CentOS 7, `sudo yum install libcurl-devel`.
-
-    Note that CentOS 6 provides an older, unsupported version of cURL (7.19). You should install a newer version from source if you are on CentOS 6.
-
-### How to Build PXF
+### Build PXF
 
 PXF uses Makefiles to build its components. PXF server component uses Gradle that is wrapped into the Makefile for convenience.
 
 ```bash
-cd ~/workspace/pxf
+cd ~/pxf
 
-# Compile & Test PXF
+# Compile PXF
 make
-
-# Only run unit tests
-make test
 ```
 
-### How to Install PXF
+### Install PXF
 
-To install PXF, first make sure that the user has sufficient permissions in the `$GPHOME` and `$PXF_HOME` directories to perform the installation. It's recommended to change ownership to match the installing user. For example, when installing PXF as user `gpadmin` under `/usr/local/cloudberrydb`:
+To install PXF, first make sure that the user has sufficient permissions in the `$GPHOME` and `$PXF_HOME` directories to perform the installation. It's recommended to change ownership to match the installing user. For example, when installing PXF as user `gpadmin` under `/usr/local/cloudberry-db`:
 
 ```bash
-export GPHOME=/usr/local/cloudberrydb
+mkdir -p /usr/local/pxf
+export GPHOME=/usr/local/cloudberry-db
 export PXF_HOME=/usr/local/pxf
 export PXF_BASE=${HOME}/pxf-base
 chown -R gpadmin:gpadmin "${GPHOME}" "${PXF_HOME}"

Review Comment:
   No. I am talking about changing file permissions: `chown -R gpadmin:gpadmin "${GPHOME}" "${PXF_HOME}"`.
   
   TLDR: **Let's leave it AS IS for now**
   
   PXF is by design broken here:
   ```
   pxf register - install extension to $GPHOME
   pxf prepare - creates configuration in $PXF_BASE
   ```
   This is being executed on all hosts using standard passwordless ssh => it is executed using `gpadmin` user. That's why
   
   > It's recommended to change ownership to match the installing user.
   
   However from security stand point it is bad idea - ideally local file system should be read-only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org


Re: [PR] ASF: Update Apache compliance and branding migration [cloudberry-pxf]

Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on code in PR #55:
URL: https://github.com/apache/cloudberry-pxf/pull/55#discussion_r2772002181


##########
README.md:
##########
@@ -78,43 +74,35 @@ To build PXF, you must have:
     go install github.com/onsi/ginkgo/ginkgo@latest
     ```
 
-5. cURL (7.29 or later):
-
-    To install cURL devel package on CentOS 7, `sudo yum install libcurl-devel`.
-
-    Note that CentOS 6 provides an older, unsupported version of cURL (7.19). You should install a newer version from source if you are on CentOS 6.
-
-### How to Build PXF
+### Build PXF
 
 PXF uses Makefiles to build its components. PXF server component uses Gradle that is wrapped into the Makefile for convenience.
 
 ```bash
-cd ~/workspace/pxf
+cd ~/pxf
 
-# Compile & Test PXF
+# Compile PXF
 make
-
-# Only run unit tests
-make test
 ```
 
-### How to Install PXF
+### Install PXF
 
-To install PXF, first make sure that the user has sufficient permissions in the `$GPHOME` and `$PXF_HOME` directories to perform the installation. It's recommended to change ownership to match the installing user. For example, when installing PXF as user `gpadmin` under `/usr/local/cloudberrydb`:
+To install PXF, first make sure that the user has sufficient permissions in the `$GPHOME` and `$PXF_HOME` directories to perform the installation. It's recommended to change ownership to match the installing user. For example, when installing PXF as user `gpadmin` under `/usr/local/cloudberry-db`:
 
 ```bash
-export GPHOME=/usr/local/cloudberrydb
+mkdir -p /usr/local/pxf
+export GPHOME=/usr/local/cloudberry-db
 export PXF_HOME=/usr/local/pxf
 export PXF_BASE=${HOME}/pxf-base
 chown -R gpadmin:gpadmin "${GPHOME}" "${PXF_HOME}"

Review Comment:
   Just found we have done it in the beginning. So let me remove this line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org


Re: [PR] ASF: Update Apache compliance and branding migration [cloudberry-pxf]

Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe merged PR #55:
URL: https://github.com/apache/cloudberry-pxf/pull/55


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org


Re: [PR] ASF: Update Apache compliance and branding migration [cloudberry-pxf]

Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on PR #55:
URL: https://github.com/apache/cloudberry-pxf/pull/55#issuecomment-3870298100

   > Reviewed, most changes added LICENSE info to align ASF policy.
   > 
   > Debian and RPM packaging could be further improved, but this should be discussed elsewhere. I also agree with removing dependencies from the cloudberry-db package as pxf does not depend on the main cloudberry package.
   
   Thanks @leborchuk for your review. Now I tested a few times, and the RPM/DEB packages can be generated and installed successfully. Let's merge this PR first. If any more questions, we can fix them later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org


Re: [PR] ASF: Update Apache compliance and branding migration [cloudberry-pxf]

Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on code in PR #55:
URL: https://github.com/apache/cloudberry-pxf/pull/55#discussion_r2780935556


##########
README.md:
##########
@@ -78,43 +74,35 @@ To build PXF, you must have:
     go install github.com/onsi/ginkgo/ginkgo@latest
     ```
 
-5. cURL (7.29 or later):
-
-    To install cURL devel package on CentOS 7, `sudo yum install libcurl-devel`.
-
-    Note that CentOS 6 provides an older, unsupported version of cURL (7.19). You should install a newer version from source if you are on CentOS 6.
-
-### How to Build PXF
+### Build PXF
 
 PXF uses Makefiles to build its components. PXF server component uses Gradle that is wrapped into the Makefile for convenience.
 
 ```bash
-cd ~/workspace/pxf
+cd ~/pxf
 
-# Compile & Test PXF
+# Compile PXF
 make
-
-# Only run unit tests
-make test
 ```
 
-### How to Install PXF
+### Install PXF
 
-To install PXF, first make sure that the user has sufficient permissions in the `$GPHOME` and `$PXF_HOME` directories to perform the installation. It's recommended to change ownership to match the installing user. For example, when installing PXF as user `gpadmin` under `/usr/local/cloudberrydb`:
+To install PXF, first make sure that the user has sufficient permissions in the `$GPHOME` and `$PXF_HOME` directories to perform the installation. It's recommended to change ownership to match the installing user. For example, when installing PXF as user `gpadmin` under `/usr/local/cloudberry-db`:
 
 ```bash
-export GPHOME=/usr/local/cloudberrydb
+mkdir -p /usr/local/pxf
+export GPHOME=/usr/local/cloudberry-db
 export PXF_HOME=/usr/local/pxf
 export PXF_BASE=${HOME}/pxf-base
 chown -R gpadmin:gpadmin "${GPHOME}" "${PXF_HOME}"

Review Comment:
   Got it. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org


Re: [PR] ASF: Update Apache compliance and branding migration [cloudberry-pxf]

Posted by "ostinru (via GitHub)" <gi...@apache.org>.
ostinru commented on code in PR #55:
URL: https://github.com/apache/cloudberry-pxf/pull/55#discussion_r2768521739


##########
README.md:
##########
@@ -78,43 +74,35 @@ To build PXF, you must have:
     go install github.com/onsi/ginkgo/ginkgo@latest
     ```
 
-5. cURL (7.29 or later):
-
-    To install cURL devel package on CentOS 7, `sudo yum install libcurl-devel`.
-
-    Note that CentOS 6 provides an older, unsupported version of cURL (7.19). You should install a newer version from source if you are on CentOS 6.
-
-### How to Build PXF
+### Build PXF
 
 PXF uses Makefiles to build its components. PXF server component uses Gradle that is wrapped into the Makefile for convenience.
 
 ```bash
-cd ~/workspace/pxf
+cd ~/pxf
 
-# Compile & Test PXF
+# Compile PXF
 make
-
-# Only run unit tests
-make test
 ```
 
-### How to Install PXF
+### Install PXF
 
-To install PXF, first make sure that the user has sufficient permissions in the `$GPHOME` and `$PXF_HOME` directories to perform the installation. It's recommended to change ownership to match the installing user. For example, when installing PXF as user `gpadmin` under `/usr/local/cloudberrydb`:
+To install PXF, first make sure that the user has sufficient permissions in the `$GPHOME` and `$PXF_HOME` directories to perform the installation. It's recommended to change ownership to match the installing user. For example, when installing PXF as user `gpadmin` under `/usr/local/cloudberry-db`:
 
 ```bash
-export GPHOME=/usr/local/cloudberrydb
+mkdir -p /usr/local/pxf
+export GPHOME=/usr/local/cloudberry-db
 export PXF_HOME=/usr/local/pxf
 export PXF_BASE=${HOME}/pxf-base
 chown -R gpadmin:gpadmin "${GPHOME}" "${PXF_HOME}"

Review Comment:
   `${GPHOME}` shouldn't be writable by `gpadmin` user (it should belong to `root`): Advisory that gained gpadmin user shouldn't be able to replace PXF binaries or add new binaries to $PATH (something like `/usr/local/pxf/bin/ls`).
   
   PS: I also don't like idea having `${PXF_HOME}` editable by gpadmin. However it is the way PXF works (e.g. almost all `pxf-cli` commands changes PXF_HOME's content).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org


Re: [PR] ASF: Update Apache compliance and branding migration [cloudberry-pxf]

Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on code in PR #55:
URL: https://github.com/apache/cloudberry-pxf/pull/55#discussion_r2771999324


##########
README.md:
##########
@@ -78,43 +74,35 @@ To build PXF, you must have:
     go install github.com/onsi/ginkgo/ginkgo@latest
     ```
 
-5. cURL (7.29 or later):
-
-    To install cURL devel package on CentOS 7, `sudo yum install libcurl-devel`.
-
-    Note that CentOS 6 provides an older, unsupported version of cURL (7.19). You should install a newer version from source if you are on CentOS 6.
-
-### How to Build PXF
+### Build PXF
 
 PXF uses Makefiles to build its components. PXF server component uses Gradle that is wrapped into the Makefile for convenience.
 
 ```bash
-cd ~/workspace/pxf
+cd ~/pxf
 
-# Compile & Test PXF
+# Compile PXF
 make
-
-# Only run unit tests
-make test
 ```
 
-### How to Install PXF
+### Install PXF
 
-To install PXF, first make sure that the user has sufficient permissions in the `$GPHOME` and `$PXF_HOME` directories to perform the installation. It's recommended to change ownership to match the installing user. For example, when installing PXF as user `gpadmin` under `/usr/local/cloudberrydb`:
+To install PXF, first make sure that the user has sufficient permissions in the `$GPHOME` and `$PXF_HOME` directories to perform the installation. It's recommended to change ownership to match the installing user. For example, when installing PXF as user `gpadmin` under `/usr/local/cloudberry-db`:
 
 ```bash
-export GPHOME=/usr/local/cloudberrydb
+mkdir -p /usr/local/pxf
+export GPHOME=/usr/local/cloudberry-db
 export PXF_HOME=/usr/local/pxf
 export PXF_BASE=${HOME}/pxf-base
 chown -R gpadmin:gpadmin "${GPHOME}" "${PXF_HOME}"

Review Comment:
   Good catch. I changed it to `source /usr/local/cloudberry-db/cloudberry-env.sh` in commit https://github.com/apache/cloudberry-pxf/pull/55/commits/5a5f5cc0ea52d149dcea07520902e9846dbf1797. Does it look good?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org


Re: [PR] ASF: Update Apache compliance and branding migration [cloudberry-pxf]

Posted by "ostinru (via GitHub)" <gi...@apache.org>.
ostinru commented on code in PR #55:
URL: https://github.com/apache/cloudberry-pxf/pull/55#discussion_r2772726954


##########
README.md:
##########
@@ -78,43 +74,35 @@ To build PXF, you must have:
     go install github.com/onsi/ginkgo/ginkgo@latest
     ```
 
-5. cURL (7.29 or later):
-
-    To install cURL devel package on CentOS 7, `sudo yum install libcurl-devel`.
-
-    Note that CentOS 6 provides an older, unsupported version of cURL (7.19). You should install a newer version from source if you are on CentOS 6.
-
-### How to Build PXF
+### Build PXF
 
 PXF uses Makefiles to build its components. PXF server component uses Gradle that is wrapped into the Makefile for convenience.
 
 ```bash
-cd ~/workspace/pxf
+cd ~/pxf
 
-# Compile & Test PXF
+# Compile PXF
 make
-
-# Only run unit tests
-make test
 ```
 
-### How to Install PXF
+### Install PXF
 
-To install PXF, first make sure that the user has sufficient permissions in the `$GPHOME` and `$PXF_HOME` directories to perform the installation. It's recommended to change ownership to match the installing user. For example, when installing PXF as user `gpadmin` under `/usr/local/cloudberrydb`:
+To install PXF, first make sure that the user has sufficient permissions in the `$GPHOME` and `$PXF_HOME` directories to perform the installation. It's recommended to change ownership to match the installing user. For example, when installing PXF as user `gpadmin` under `/usr/local/cloudberry-db`:
 
 ```bash
-export GPHOME=/usr/local/cloudberrydb
+mkdir -p /usr/local/pxf
+export GPHOME=/usr/local/cloudberry-db
 export PXF_HOME=/usr/local/pxf
 export PXF_BASE=${HOME}/pxf-base
 chown -R gpadmin:gpadmin "${GPHOME}" "${PXF_HOME}"

Review Comment:
   No. I am talking about changing file permissions: `chown -R gpadmin:gpadmin "${GPHOME}" "${PXF_HOME}"`.
   
   TLDR: **Let's leave it AS IS for now**
   
   PXF is by design broken here:
   ```
   pxf register - install extension to $GPHOME
   pxf prepare - creates configuration in $PXF_BASE
   ```
   These commands are being executed on all hosts using standard passwordless ssh => it is executed using `gpadmin` user. That's why
   
   > It's recommended to change ownership to match the installing user.
   
   However from security stand point it is bad idea - ideally local file system should be read-only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org


Re: [PR] ASF: Update Apache compliance and branding migration [cloudberry-pxf]

Posted by "ostinru (via GitHub)" <gi...@apache.org>.
ostinru commented on code in PR #55:
URL: https://github.com/apache/cloudberry-pxf/pull/55#discussion_r2772795837


##########
README.md:
##########
@@ -78,43 +74,35 @@ To build PXF, you must have:
     go install github.com/onsi/ginkgo/ginkgo@latest
     ```
 
-5. cURL (7.29 or later):
-
-    To install cURL devel package on CentOS 7, `sudo yum install libcurl-devel`.
-
-    Note that CentOS 6 provides an older, unsupported version of cURL (7.19). You should install a newer version from source if you are on CentOS 6.
-
-### How to Build PXF
+### Build PXF
 
 PXF uses Makefiles to build its components. PXF server component uses Gradle that is wrapped into the Makefile for convenience.
 
 ```bash
-cd ~/workspace/pxf
+cd ~/pxf
 
-# Compile & Test PXF
+# Compile PXF
 make
-
-# Only run unit tests
-make test
 ```
 
-### How to Install PXF
+### Install PXF
 
-To install PXF, first make sure that the user has sufficient permissions in the `$GPHOME` and `$PXF_HOME` directories to perform the installation. It's recommended to change ownership to match the installing user. For example, when installing PXF as user `gpadmin` under `/usr/local/cloudberrydb`:
+To install PXF, first make sure that the user has sufficient permissions in the `$GPHOME` and `$PXF_HOME` directories to perform the installation. It's recommended to change ownership to match the installing user. For example, when installing PXF as user `gpadmin` under `/usr/local/cloudberry-db`:
 
 ```bash
-export GPHOME=/usr/local/cloudberrydb
+mkdir -p /usr/local/pxf
+export GPHOME=/usr/local/cloudberry-db
 export PXF_HOME=/usr/local/pxf
 export PXF_BASE=${HOME}/pxf-base
 chown -R gpadmin:gpadmin "${GPHOME}" "${PXF_HOME}"

Review Comment:
   It's irrelevant to current PR. Let's move on.
   
   cc: @MisterRaindrop to point to PXF design flaw.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org