You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Randgalt <gi...@git.apache.org> on 2017/03/15 14:54:26 UTC
[GitHub] zookeeper pull request #192: ZOOKEEPER-2719: Pull changes for TTL Nodes into...
GitHub user Randgalt opened a pull request:
https://github.com/apache/zookeeper/pull/192
ZOOKEEPER-2719: Pull changes for TTL Nodes into 3.5 branch
This PR cherry-picks changes for TTL nodes (ZOOKEEPER-2169) and the CLI for it (ZOOKEEPER-2608) into branch-3.5.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Randgalt/zookeeper ZOOKEEPER-2719
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #192
----
commit 66fdccbc115a7080225431da87a8b3e34453d854
Author: randgalt <jo...@jordanzimmerman.com>
Date: 2016-09-28T08:32:50Z
This patch takes advantage of 3.5's container support. Most of the work needed to support TTLs is there already.
In order not to break on-disk and protocol compatibility the ephemeralOwner is yet-again overloaded to have special meaning.
New opcodes and transaction records had to be added in a similar manner to Containers
NOTE: This patch was originally in Review Board and was moved to Github for ease/convenience. RB link:
https://reviews.apache.org/r/46983/#comment214810
commit 64f77a518d9c9608375cf06855439d8c06928fb1
Author: randgalt <jo...@jordanzimmerman.com>
Date: 2017-03-14T19:07:36Z
cleaned up some doc merge issues
commit 39b969b3fb753f41e8f981d4d726e02853320cc7
Author: randgalt <jo...@jordanzimmerman.com>
Date: 2016-10-09T10:23:38Z
Removed bogus import
commit 6343001d89c132c9b4fa7ee8b035acf40bd18f21
Author: randgalt <jo...@jordanzimmerman.com>
Date: 2016-10-09T10:43:41Z
Added ttl option to CLI create command
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #192: ZOOKEEPER-2719: Pull changes for TTL Nodes into 3.5 br...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/192
LGTM. I did some testing using CLI and it works as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #192: ZOOKEEPER-2719: Pull changes for TTL Nodes into 3.5 br...
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/192
merged into `branch-3.5`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #192: ZOOKEEPER-2719: Pull changes for TTL Nodes into...
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt closed the pull request at:
https://github.com/apache/zookeeper/pull/192
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #192: ZOOKEEPER-2719: Pull changes for TTL Nodes into 3.5 br...
Posted by eribeiro <gi...@git.apache.org>.
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/192
Hi @Randgalt, congrats on getting this PR ported to 3.5! :smiley: Please, could you close this PR as it has been merged? Best regards!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---