You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by "craigcondit (via GitHub)" <gi...@apache.org> on 2023/04/05 12:46:50 UTC

[GitHub] [yunikorn-k8shim] craigcondit commented on a diff in pull request #568: [YUNIKORN-1677] move to simple go based web server for e2e tests.

craigcondit commented on code in PR #568:
URL: https://github.com/apache/yunikorn-k8shim/pull/568#discussion_r1158470831


##########
deployments/image/webtest/Dockerfile:
##########
@@ -15,23 +15,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-ARG ARCH=
-FROM ${ARCH}nginx:stable-alpine
-
-# Home location for all data and configs
-ENV HOME=/opt/yunikorn
+# Imagestage: use scratch base image
+FROM --platform=$TARGETPLATFORM scratch
+COPY --chown=4444:0 document/index.html /html/

Review Comment:
   Use `--chown=0:0` here. There's no need to make the content owned by the web user.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org