You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by ZoneMayor <gi...@git.apache.org> on 2015/12/11 16:03:20 UTC

[GitHub] kafka pull request: KAFKA-2875:

GitHub user ZoneMayor opened a pull request:

    https://github.com/apache/kafka/pull/669

    KAFKA-2875:

    Hi @ijuma 
    I repopened this PR;
    I make slf4jlog4j12 dependency version to be 1.7.13, by this way, the 1.7.6 transitive dependency version will be overriten I think;
    From my point of view, a proper way to fix the multi binding of slf4j is to specify the classpath inside of parent script of kafka-run-class.sh, like kafka-topics.sh, kafka-console-consumer.sh;
    As a result, kafka-run-class.sh will be told which command to run and where to find jars contains the class for the command;
    Am I right?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ZoneMayor/kafka trunk-KAFKA-2875

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/669.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #669
    
----
commit 95374147a28208d4850f6e73f714bf418935fc2d
Author: ZoneMayor <ji...@126.com>
Date:   2015-11-27T03:49:34Z

    Merge pull request #1 from apache/trunk
    
    merge

commit cec5b48b651a7efd3900cfa3c1fd0ab1eeeaa3ec
Author: ZoneMayor <ji...@126.com>
Date:   2015-12-01T10:44:02Z

    Merge pull request #2 from apache/trunk
    
    2015-12-1

commit a119d547bf1741625ce0627073c7909992a20f15
Author: ZoneMayor <ji...@126.com>
Date:   2015-12-04T13:42:27Z

    Merge pull request #3 from apache/trunk
    
    2015-12-04#KAFKA-2893

commit b767a8dff85fc71c75d4cf5178c3f6f03ff81bfc
Author: ZoneMayor <ji...@126.com>
Date:   2015-12-09T10:42:30Z

    Merge pull request #5 from apache/trunk
    
    2015-12-9

commit 0070c2d71d06ee8baa1cddb3451cd5af6c6b1d4a
Author: ZoneMayor <ji...@126.com>
Date:   2015-12-11T14:50:30Z

    Merge pull request #8 from apache/trunk
    
    2015-12-11

commit fe1f7fdb73c75dea5247bc5c4c9e78fdad6fea37
Author: jinxing <ji...@fenbi.com>
Date:   2015-12-11T14:52:24Z

    KAFKA-2875: Class path contains multiple SLF4J bindings warnings when using scripts under bin

commit 5047602438c2e6d66514ebfed07002404cc01578
Author: jinxing <ji...@fenbi.com>
Date:   2015-12-11T14:54:43Z

    KAFKA-2875: WIP

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request: KAFKA-2875: Class path contains multiple SLF4J...

Posted by ZoneMayor <gi...@git.apache.org>.
Github user ZoneMayor closed the pull request at:

    https://github.com/apache/kafka/pull/669


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---