[GitHub] [flink] CrynetLogistics commented on a change in pull request #18733: [FLINK-26064][connectors/firehose,kinesis] Using own event loop group…

[GitBox <gi...@apache.org>]

CrynetLogistics commented on a change in pull request #18733:
URL: https://github.com/apache/flink/pull/18733#discussion_r804789573



##########
File path: flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSGeneralUtil.java
##########
@@ -274,6 +275,7 @@ public static SdkAsyncHttpClient createAsyncHttpClient(
     public static SdkAsyncHttpClient createAsyncHttpClient(
             final AttributeMap config, final NettyNioAsyncHttpClient.Builder httpClientBuilder) {
         httpClientBuilder
+                .eventLoopGroupBuilder(SdkEventLoopGroup.builder())

Review comment:
       Looks like the httpClient closes the ELG when it itself is closed: https://github.com/aws/aws-sdk-java-v2/blob/master/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.java#:~:text=public%20void%20close()%20%7B




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org