[GitHub] vjagadish1989 commented on a change in pull request #899: SAMZA-2091: Update ZkClient in samza-standalone to use string serializer

[GitBox <gi...@apache.org>]

vjagadish1989 commented on a change in pull request #899:  SAMZA-2091: Update ZkClient in samza-standalone to use string serializer
URL: https://github.com/apache/samza/pull/899#discussion_r256973855
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/zk/ZkBarrierForVersionUpgrade.java
 ##########
 @@ -155,10 +161,10 @@ public void join(String version, String participantId) {
    */
   public void expire(String version) {
     String barrierStatePath = keyBuilder.getBarrierStatePath(version);
-    State barrierState = zkUtils.getZkClient().readData(barrierStatePath);
+    State barrierState = State.valueOf(zkUtils.getZkClient().readData(barrierStatePath));
 
 Review comment:
   FYI, I don't think anyone disagrees that this patch is the way forward..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services