[GitHub] williaster commented on a change in pull request #5418: Retire dashboard v1 (js and python)

[GitBox <gi...@apache.org>]

williaster commented on a change in pull request #5418: Retire dashboard v1 (js and python)
URL: https://github.com/apache/incubator-superset/pull/5418#discussion_r203553274
 
 

 ##########
 File path: superset/assets/src/dashboard/components/SaveModal.jsx
 ##########
 @@ -104,16 +103,12 @@ class SaveModal extends React.PureComponent {
   }
 
   render() {
-    const { isV2Preview } = this.props;
     return (
       <ModalTrigger
         ref={this.setModalRef}
         isMenuItem={this.props.isMenuItem}
         triggerNode={this.props.triggerNode}
-        modalTitle={t(
-          'Save Dashboard%s',
-          isV2Preview ? ' (⚠️ all saved dashboards will be V2)' : '',
-        )}
+        modalTitle={t('Save Dashboard%s')}
 
 Review comment:
   extra `%` I think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org