[jira] [Work logged] (CURATOR-526) Error logged for valid config - "Invalid config event received: {properties}"

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CURATOR-526?focusedWorklogId=631764&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-631764 ]

ASF GitHub Bot logged work on CURATOR-526:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Jul/21 16:34
            Start Date: 30/Jul/21 16:34
    Worklog Time Spent: 10m 
      Work Description: leandrodalbo commented on a change in pull request #382:
URL: https://github.com/apache/curator/pull/382#discussion_r680071580



##########
File path: curator-framework/src/main/java/org/apache/curator/framework/imps/EnsembleTracker.java
##########
@@ -211,7 +211,7 @@ private void processConfigData(byte[] data) throws Exception
             }
             else
             {
-                log.error("Invalid config event received: {}", properties);
+                log.debug("Invalid config event received: {}", properties);

Review comment:
        @VisibleForTesting
       public static String configToConnectionString(QuorumVerifier data) throws Exception {
           StringBuilder sb = new StringBuilder();
           Iterator var2 = data.getAllMembers().values().iterator();
   
           while(var2.hasNext()) {
               QuorumServer server = (QuorumServer)var2.next();
               if (server.clientAddr != null) {
                   if (sb.length() != 0) {
                       sb.append(",");
                   }
   
                   String hostAddress;
                   if (server.clientAddr.getAddress().isAnyLocalAddress()) {
                       hostAddress = Compatibility.getHostAddress(server);
                   } else {
                       hostAddress = server.clientAddr.getAddress().getHostAddress();
                   }
   
                   sb.append(hostAddress).append(":").append(server.clientAddr.getPort());
               }
           }
   
           return sb.toString();
       }
   
   - I think it is processing the version=0 like another server more when it shouldn't. 
   - Do we know if this is affecting any functionality?
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 631764)
    Time Spent: 1h 40m  (was: 1.5h)

> Error logged for valid config - "Invalid config event received: {properties}"
> -----------------------------------------------------------------------------
>
>                 Key: CURATOR-526
>                 URL: https://issues.apache.org/jira/browse/CURATOR-526
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 4.0.1
>            Reporter: Rajesh Singh
>            Assignee: Enrico Olivelli
>            Priority: Major
>             Fix For: 5.2.0
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Curator Framework v4.0.1 - EnsembleTracker.processConfigData(byte[] data) (Ln: 157)- seems to be logging error for valid configs when the config string obtained from Zookeeper does not have the client info in it. 
> As per the docs the config string should conform to below formats:
> *server_config* or *server_config*;*client_config* where server_config is host:port:port or host:port:port:type and client_config is port or host:port
> In our case it conforms to the first pattern i.e. *server_config* with host:port:port:type



--
This message was sent by Atlassian Jira
(v8.3.4#803005)