You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/09/06 10:03:04 UTC

Review Request 62116: Excluded invalid offers from abnormal termination metrics.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62116/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Joseph Wu.


Repository: mesos


Description
-------

Some example frameworks consider all TASK_LOST updates as a sign of
an abnormal termination. However, the task can fail to run due to
the offer becoming invalid, which is inherently racy and does not
mean the task has terminated abnormally.


Diffs
-----

  src/examples/balloon_framework.cpp 1a97f56c3e217c58b408949306b92f19caa5f6c6 
  src/examples/disk_full_framework.cpp f9d5af5e45d5736581ce2c5395c741c995332136 
  src/examples/long_lived_framework.cpp 3de4a0280c41db5dcf656ac89cb4168060190108 


Diff: https://reviews.apache.org/r/62116/diff/1/


Testing
-------

make check


Thanks,

Alexander Rukletsov

Re: Review Request 62116: Excluded invalid offers from abnormal termination metrics.

Posted by Joseph Wu <jo...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62116/#review184700
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On Sept. 6, 2017, 3:03 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62116/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2017, 3:03 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some example frameworks consider all TASK_LOST updates as a sign of
> an abnormal termination. However, the task can fail to run due to
> the offer becoming invalid, which is inherently racy and does not
> mean the task has terminated abnormally.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp 1a97f56c3e217c58b408949306b92f19caa5f6c6 
>   src/examples/disk_full_framework.cpp f9d5af5e45d5736581ce2c5395c741c995332136 
>   src/examples/long_lived_framework.cpp 3de4a0280c41db5dcf656ac89cb4168060190108 
> 
> 
> Diff: https://reviews.apache.org/r/62116/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 62116: Excluded invalid offers from abnormal termination metrics.

Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62116/#review184721
-----------------------------------------------------------


Ship it!




Ship It!

- Chun-Hung Hsiao


On Sept. 6, 2017, 10:03 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62116/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2017, 10:03 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some example frameworks consider all TASK_LOST updates as a sign of
> an abnormal termination. However, the task can fail to run due to
> the offer becoming invalid, which is inherently racy and does not
> mean the task has terminated abnormally.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp 1a97f56c3e217c58b408949306b92f19caa5f6c6 
>   src/examples/disk_full_framework.cpp f9d5af5e45d5736581ce2c5395c741c995332136 
>   src/examples/long_lived_framework.cpp 3de4a0280c41db5dcf656ac89cb4168060190108 
> 
> 
> Diff: https://reviews.apache.org/r/62116/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 62116: Excluded invalid offers from abnormal termination metrics.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62116/#review184656
-----------------------------------------------------------



FAIL: Mesos tests failed to run

Reviews applied: [62116]

Logs available here: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62116/logs

- Mesos Reviewbot Windows


On Sept. 6, 2017, 10:03 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62116/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2017, 10:03 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some example frameworks consider all TASK_LOST updates as a sign of
> an abnormal termination. However, the task can fail to run due to
> the offer becoming invalid, which is inherently racy and does not
> mean the task has terminated abnormally.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp 1a97f56c3e217c58b408949306b92f19caa5f6c6 
>   src/examples/disk_full_framework.cpp f9d5af5e45d5736581ce2c5395c741c995332136 
>   src/examples/long_lived_framework.cpp 3de4a0280c41db5dcf656ac89cb4168060190108 
> 
> 
> Diff: https://reviews.apache.org/r/62116/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 62116: Excluded invalid offers from abnormal termination metrics.

Posted by Armand Grillet <ag...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62116/#review184667
-----------------------------------------------------------



LGTM.

- Armand Grillet


On Sept. 6, 2017, 10:03 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62116/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2017, 10:03 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some example frameworks consider all TASK_LOST updates as a sign of
> an abnormal termination. However, the task can fail to run due to
> the offer becoming invalid, which is inherently racy and does not
> mean the task has terminated abnormally.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp 1a97f56c3e217c58b408949306b92f19caa5f6c6 
>   src/examples/disk_full_framework.cpp f9d5af5e45d5736581ce2c5395c741c995332136 
>   src/examples/long_lived_framework.cpp 3de4a0280c41db5dcf656ac89cb4168060190108 
> 
> 
> Diff: https://reviews.apache.org/r/62116/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>