[impala] 02/02: IMPALA-12283: Remove Hive libs from PYTHONPATH

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 0df29b4105c0e884cabde3289874b9850e3df21d
Author: Joe McDonnell <jo...@cloudera.com>
AuthorDate: Mon Apr 3 21:20:22 2023 -0700

    IMPALA-12283: Remove Hive libs from PYTHONPATH
    
    bin/set-pythonpath.sh include $HIVE_HOME/lib/py. This is a
    historical thing that is no longer needed today. Impala
    should not be getting Python code directly from Hive. As a
    cleanup, this removes $HIVE_HOME/lib/py from the
    PYTHONPATH.
    
    Testing:
     - Ran a core job
    
    Change-Id: I56d1ae3b1433d6240159f20da4680888b5f37357
    Reviewed-on: http://gerrit.cloudera.org:8080/19689
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
    Reviewed-by: Michael Smith <mi...@cloudera.com>
---
 README-build.md       | 2 +-
 bin/set-pythonpath.sh | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/README-build.md b/README-build.md
index 51f750552..d96827006 100644
--- a/README-build.md
+++ b/README-build.md
@@ -35,7 +35,7 @@ can do so through the environment variables and scripts listed below.
 | IMPALA_JDK_VERSION | "system" | Set to 8 or 11 to select a system Java version. Default will set JAVA_HOME based on the javac symlink in PATH. |
 | JAVA | "${JAVA_HOME}/bin/java" | Java binary location. |
 | CLASSPATH | | See bin/set-classpath.sh for details. |
-| PYTHONPATH |  Will be changed to include: "${IMPALA_HOME}/shell/gen-py" "${IMPALA_HOME}/testdata" "${THRIFT_PY_HOME}/python/lib/python2.7/site-packages" "${HIVE_HOME}/lib/py" |
+| PYTHONPATH |  Will be changed to include: "${IMPALA_HOME}/shell/gen-py" "${IMPALA_HOME}/testdata" "${THRIFT_PY_HOME}/python/lib/python2.7/site-packages" |
 
 ## Source Directories for Impala
 
diff --git a/bin/set-pythonpath.sh b/bin/set-pythonpath.sh
index f2823ab55..9e1c933d1 100755
--- a/bin/set-pythonpath.sh
+++ b/bin/set-pythonpath.sh
@@ -42,6 +42,3 @@ for PYTHON_DIR in ${THRIFT_PY_HOME}/python/lib{64,}; do
       PYTHONPATH=${PYTHONPATH}:${PKG_DIR}/
     done
 done
-
-# Add Hive after Thrift because Hive supplies its own Thrift modules
-PYTHONPATH=${PYTHONPATH}:${HIVE_HOME}/lib/py