You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/06/28 01:31:43 UTC

[GitHub] [superset] lyndsiWilliams opened a new pull request, #20515: feat(SqlLab): Move Save Dataset to Split Save Query Button

lyndsiWilliams opened a new pull request, #20515:
URL: https://github.com/apache/superset/pull/20515

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   This changes the current save query button into a split save button if the database has "Allow this database to be explored" enabled. When the user clicks the caret section of the button, they can now save the query as a dataset.
   
   `Bonus`: In order to create this button, I conveniently needed to fix the styling on the "Run" query split button. The split line now goes all the way through the button and the caret is centered.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   #### BEFORE:
   ![saveButtonBefore](https://user-images.githubusercontent.com/55605634/176063560-492b124a-40ce-4aaf-8745-691ddfa271ef.png)
   
   #### AFTER:
   ![splitSaveButtonAfter](https://user-images.githubusercontent.com/55605634/176063585-59e7074d-cec6-4bd3-b26e-276fd5a1a090.png)
   ![saveButtonAfter](https://user-images.githubusercontent.com/55605634/176063591-55dafb31-a843-4052-8372-a10bb9d0526a.png)
   ![runButtonAfter](https://user-images.githubusercontent.com/55605634/176067479-c5ba02bc-834a-4d0b-8e01-3b1eb0787c65.png)
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   - From SqlLab, open a query for a database that has "Allow this database to be explored" enabled.
     - Observe the new split save button
       - Click the "Save" section of the button to see the save query modal
       - Click the caret `v` section of the button, then click "Save dataset" to see the save dataset modal
       - Both of these modals should be fully functional
   - From SqlLab, open a query for a database that does NOT have "Allow this database to be explored" enabled.
     - Observe that the save button is a normal button, not split
       - Clicking this button should show the save query modal
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] lyndsiWilliams commented on pull request #20515: feat(SqlLab): Change Save Dataset Button to Split Save Query Button

Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #20515:
URL: https://github.com/apache/superset/pull/20515#issuecomment-1194388481

   Continued in this PR: https://github.com/apache/superset/pull/20852


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] lyndsiWilliams commented on pull request #20515: feat(SqlLab): Change Save Dataset Button to Split Save Query Button

Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #20515:
URL: https://github.com/apache/superset/pull/20515#issuecomment-1170691625

   /testenv up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] lyndsiWilliams closed pull request #20515: feat(SqlLab): Change Save Dataset Button to Split Save Query Button

Posted by GitBox <gi...@apache.org>.
lyndsiWilliams closed pull request #20515: feat(SqlLab): Change Save Dataset Button to Split Save Query Button
URL: https://github.com/apache/superset/pull/20515


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] github-actions[bot] commented on pull request #20515: feat(SqlLab): Change Save Dataset Button to Split Save Query Button

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20515:
URL: https://github.com/apache/superset/pull/20515#issuecomment-1170692559

   @lyndsiWilliams Ephemeral environment spinning up at http://35.89.226.234:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] lyndsiWilliams commented on pull request #20515: feat(SqlLab): Change Save Dataset Button to Split Save Query Button

Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #20515:
URL: https://github.com/apache/superset/pull/20515#issuecomment-1170658402

   Closing to hard reset ephemeral env.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] github-actions[bot] commented on pull request #20515: feat(SqlLab): Move Save Dataset to Split Save Query Button

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20515:
URL: https://github.com/apache/superset/pull/20515#issuecomment-1170655689

   @lyndsiWilliams Ephemeral environment spinning up at http://54.244.147.69:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] github-actions[bot] commented on pull request #20515: feat(SqlLab): Change Save Dataset Button to Split Save Query Button

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20515:
URL: https://github.com/apache/superset/pull/20515#issuecomment-1171466411

   Ephemeral environment shutdown and build artifacts deleted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] lyndsiWilliams closed pull request #20515: feat(SqlLab): Change Save Dataset Button to Split Save Query Button

Posted by GitBox <gi...@apache.org>.
lyndsiWilliams closed pull request #20515: feat(SqlLab): Change Save Dataset Button to Split Save Query Button
URL: https://github.com/apache/superset/pull/20515


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] lyndsiWilliams commented on pull request #20515: feat(SqlLab): Move Save Dataset to Split Save Query Button

Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #20515:
URL: https://github.com/apache/superset/pull/20515#issuecomment-1170653314

   /testenv up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] lyndsiWilliams commented on pull request #20515: feat(SqlLab): Move Save Dataset to Split Save Query Button

Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #20515:
URL: https://github.com/apache/superset/pull/20515#issuecomment-1169452622

   /testenv up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] github-actions[bot] commented on pull request #20515: feat(SqlLab): Move Save Dataset to Split Save Query Button

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20515:
URL: https://github.com/apache/superset/pull/20515#issuecomment-1169453653

   @lyndsiWilliams Ephemeral environment spinning up at http://35.87.41.32:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] commented on pull request #20515: feat(SqlLab): Move Save Dataset to Split Save Query Button

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20515:
URL: https://github.com/apache/superset/pull/20515#issuecomment-1169446643

   # [Codecov](https://codecov.io/gh/apache/superset/pull/20515?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#20515](https://codecov.io/gh/apache/superset/pull/20515?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0027fe8) into [master](https://codecov.io/gh/apache/superset/commit/daded1099262a694d7cc861a8a798dba4102d5e8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (daded10) will **increase** coverage by `0.04%`.
   > The diff coverage is `90.00%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #20515      +/-   ##
   ==========================================
   + Coverage   66.75%   66.79%   +0.04%     
   ==========================================
     Files        1739     1746       +7     
     Lines       65138    65209      +71     
     Branches     6898     6915      +17     
   ==========================================
   + Hits        43480    43554      +74     
   - Misses      19908    19911       +3     
   + Partials     1750     1744       -6     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `51.91% <90.00%> (+0.10%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/20515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...d/src/SqlLab/components/SaveDatasetModal/index.tsx](https://codecov.io/gh/apache/superset/pull/20515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVEYXRhc2V0TW9kYWwvaW5kZXgudHN4) | `35.61% <0.00%> (ø)` | |
   | [...frontend/src/SqlLab/components/SqlEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/20515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci9pbmRleC5qc3g=) | `51.36% <ø> (ø)` | |
   | [superset-frontend/src/SqlLab/types.ts](https://codecov.io/gh/apache/superset/pull/20515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi90eXBlcy50cw==) | `57.14% <ø> (ø)` | |
   | [...frontend/src/SqlLab/components/SaveQuery/index.tsx](https://codecov.io/gh/apache/superset/pull/20515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVRdWVyeS9pbmRleC50c3g=) | `75.00% <91.66%> (+17.10%)` | :arrow_up: |
   | [...c/SqlLab/components/RunQueryActionButton/index.tsx](https://codecov.io/gh/apache/superset/pull/20515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uL2luZGV4LnRzeA==) | `53.12% <100.00%> (ø)` | |
   | [...qlLab/components/SaveDatasetActionButton/index.tsx](https://codecov.io/gh/apache/superset/pull/20515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVEYXRhc2V0QWN0aW9uQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <100.00%> (ø)` | |
   | [...t-frontend/src/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/20515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHJvcGRvd25CdXR0b24vaW5kZXgudHN4) | `85.00% <100.00%> (+75.00%)` | :arrow_up: |
   | [...gins/legacy-plugin-chart-chord/src/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/20515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9jb250cm9sUGFuZWwudHM=) | `25.00% <0.00%> (-75.00%)` | :arrow_down: |
   | [...s/legacy-plugin-chart-calendar/src/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/20515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNhbGVuZGFyL3NyYy9jb250cm9sUGFuZWwudHM=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [...egacy-plugin-chart-country-map/src/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/20515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9jb250cm9sUGFuZWwudHM=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | ... and [71 more](https://codecov.io/gh/apache/superset/pull/20515/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/20515?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/20515?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [daded10...0027fe8](https://codecov.io/gh/apache/superset/pull/20515?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] github-actions[bot] commented on pull request #20515: feat(SqlLab): Change Save Dataset Button to Split Save Query Button

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20515:
URL: https://github.com/apache/superset/pull/20515#issuecomment-1170658571

   Ephemeral environment shutdown and build artifacts deleted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] lyndsiWilliams commented on pull request #20515: feat(SqlLab): Change Save Dataset Button to Split Save Query Button

Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #20515:
URL: https://github.com/apache/superset/pull/20515#issuecomment-1171466041

   Closing to reopen in a new PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org