You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Wei-Chiu Chuang (Jira)" <ji...@apache.org> on 2023/01/10 00:08:00 UTC
[jira] [Commented] (HDDS-7764) Potential discrepancy of key creation time may cause premature open key clean up
[ https://issues.apache.org/jira/browse/HDDS-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656347#comment-17656347 ]
Wei-Chiu Chuang commented on HDDS-7764:
---------------------------------------
[~erose] [~ckj] thoughts on this one? To be sure this is the hypothesis made after reading the code. I haven't had a test case to confirm this hypothesis.
> Potential discrepancy of key creation time may cause premature open key clean up
> --------------------------------------------------------------------------------
>
> Key: HDDS-7764
> URL: https://issues.apache.org/jira/browse/HDDS-7764
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: Ozone Manager
> Reporter: Wei-Chiu Chuang
> Priority: Major
>
> When a key is created by OMKeyCreateRequest, its creation time is set by Time.now(), which is local time.
>
> When OpenKeyCleanupService checks for expired open keys (OmMetadataManagerImpl.getExpiredOpenKeys()) it uses Instant.now() as the current time, which is UTC time.
>
> OpenKeyCleanupService may therefore pick up open keys that are not actually expired due to time zone difference.
>
> This is not currently a critical issue as with the current implemetation, open keys expires after 7 days, so the time difference isn't that critical. However, once we implement HDFS-like lease recovery and use the expiration time comparable to HDFS (1 minute/1 hour) then it is a big problem.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org