You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/23 02:28:55 UTC
[GitHub] [airflow] mik-laj opened a new pull request #16004: Handle at sign in password for Helm Chart
mik-laj opened a new pull request #16004:
URL: https://github.com/apache/airflow/pull/16004
Close: https://github.com/apache/airflow/issues/16000
I've tried to fix this bug, but I'm afraid the Helm rendering engine is missing the necessary function. Username and Password should be percent-encoded, but Helm doesn't have such a function that does it, but there's an open ticket for it. https://github.com/Masterminds/sprig/issues/248
We also cannot expect users to enter an encoded password, because we use these variables in two contexts, and sometimes it is needed encrypted and raw to others.
https://github.com/apache/airflow/blob/b66b54c83cb2efa274ba8040ce22ae719defbe75/chart/templates/_helpers.yaml#L344
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #16004: Handle at sign in password for Helm Chart
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #16004:
URL: https://github.com/apache/airflow/pull/16004#issuecomment-846562453
I found a solution. Updated and ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16004: Handle special characters in password sfor Helm Chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16004:
URL: https://github.com/apache/airflow/pull/16004#issuecomment-846582216
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #16004: Handle at sign in password for Helm Chart
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #16004:
URL: https://github.com/apache/airflow/pull/16004#issuecomment-846562453
I found a solution. Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #16004: Handle special characters in password sfor Helm Chart
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #16004:
URL: https://github.com/apache/airflow/pull/16004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org